[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4716: Package pinot-parquet and pinot-orc module into pinot-hadoop shaded jar

[GitBox <gi...@apache.org>]

fx19880617 commented on a change in pull request #4716: Package pinot-parquet and pinot-orc module into pinot-hadoop shaded jar
URL: https://github.com/apache/incubator-pinot/pull/4716#discussion_r336234235
 
 

 ##########
 File path: pinot-hadoop/pom.xml
 ##########
 @@ -103,6 +103,28 @@
       <version>${project.version}</version>
       <classifier>shaded</classifier>
     </dependency>
+    <dependency>
+      <groupId>org.apache.pinot</groupId>
+      <artifactId>pinot-parquet</artifactId>
+      <version>${project.version}</version>
+      <exclusions>
+        <exclusion>
+          <groupId>org.apache.pinot</groupId>
+          <artifactId>pinot-core</artifactId>
+        </exclusion>
+      </exclusions>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.pinot</groupId>
 
 Review comment:
   This pr aims to shade orc/parquet, so user could use this jar to create segment from parquent/orc file. Otherwise they need to drop pinot-parquet/pinot-orc jar into their classpath or do their own shading with pinot-parquet/pinot-orc to generate a fat jar.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org