[jira] [Commented] (RANGER-209) Test Patch script for Ranger

["Ashish Singh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RANGER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306126#comment-14306126 ] 

Ashish Singh commented on RANGER-209:
-------------------------------------

[~sneethiraj] Attached the new patch [0001-RANGER-209-Test-Patch-script-for-Ranger.patch|https://issues.apache.org/jira/secure/attachment/12696580/0001-RANGER-209-Test-Patch-script-for-Ranger.patch] for review. Addressed most of the items:
1. Handling the patch for both p0 and p1.
2. console logs are redirected to the log files for failure reference, it should not be  */dev/null*
3. Patch tmp directory is */tmp*, but it can be overwritten from command line using the argument  as below:

{code}

Usage: dev-support/test-patch.sh [options] patch-file | defect-number

Where:
  patch-file is a local patch file containing the changes to test
  defect-number is a JIRA defect number (e.g. 'RANGER-1234') to test (Jenkins only)

Options:
--patch-dir=<dir>      The directory for working and output files (default '/tmp')
--basedir=<dir>        The directory to apply the patch to (default current directory)
--mvn-cmd=<cmd>        The 'mvn' command to use (default $MAVEN_HOME/bin/mvn, or 'mvn')
--ps-cmd=<cmd>         The 'ps' command to use (default 'ps')
--awk-cmd=<cmd>        The 'awk' command to use (default 'awk')
--git-cmd=<cmd>        The 'git' command to use (default 'git')
--grep-cmd=<cmd>       The 'grep' command to use (default 'grep')
--patch-cmd=<cmd>      The 'patch' command to use (default 'patch')
--diff-cmd=<cmd>       The 'diff' command to use (default 'diff')
--findbugs-home=<path> Findbugs home directory (default FINDBUGS_HOME environment variable)
--dirty-workspace      Allow the local git workspace to have uncommitted changes
--run-tests            Run all tests below the base directory

Jenkins-only options:
--jenkins              Run by Jenkins (runs tests and posts results to JIRA)
--wget-cmd=<cmd>       The 'wget' command to use (default 'wget')
--jira-cmd=<cmd>       The 'jira' command to use (default 'jira')
--jira-password=<pw>   The password for the 'jira' command
{code}
 



> Test Patch script for Ranger
> ----------------------------
>
>                 Key: RANGER-209
>                 URL: https://issues.apache.org/jira/browse/RANGER-209
>             Project: Ranger
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>         Environment: Have test patch capability as part dev support, to test patches as part of Jenkins builds.
>            Reporter: Ashish Singh
>            Assignee: Ashish Singh
>            Priority: Critical
>             Fix For: 0.5.0
>
>         Attachments: 0001-RANGER-209-Test-Patch-script-for-Ranger.patch, 0001-RANGER-209-Test-Patch-script-for-Ranger.patch
>
>
> Have the Test patch capability like other apache components. For example
> https://github.com/apache/hadoop-common/blob/branch-2/dev-support/test-patch.sh



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)