You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/09/10 00:02:12 UTC
Re: Review Request: Replaced double with Duration in Timeout.
> On Aug. 30, 2012, 1:09 a.m., Vinod Kone wrote:
> > src/java/jni/org_apache_mesos_Log.cpp, line 152
> > <https://reviews.apache.org/r/6848/diff/1/?file=147350#file147350line152>
> >
> > why store into a local variable? just do Timeout(Seconds(jseconds)) as you did below.
Done.
> On Aug. 30, 2012, 1:09 a.m., Vinod Kone wrote:
> > src/master/hierarchical_allocator_process.hpp, line 441
> > <https://reviews.apache.org/r/6848/diff/1/?file=147353#file147353line441>
> >
> > s/0.0/0
Done in an earlier review.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6848/#review10867
-----------------------------------------------------------
On Aug. 30, 2012, 12:56 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6848/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2012, 12:56 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 3928b31
> src/log/network.hpp b25e995
> src/logging/logging.cpp 6909b0b
> src/master/hierarchical_allocator_process.hpp 86c9b1e
> src/tests/log_tests.cpp 85b2329
> third_party/libprocess/include/process/timeout.hpp 4a1f113
> third_party/libprocess/include/process/timer.hpp 72f7711
> third_party/libprocess/src/process.cpp 2b2d521
>
> Diff: https://reviews.apache.org/r/6848/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>