You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "222twotwotwo (via GitHub)" <gi...@apache.org> on 2026/08/26 15:08:45 UTC
[PR] Fix/quality [dubbo-getty]
222twotwotwo opened a new pull request, #144:
URL: https://github.com/apache/dubbo-getty/pull/144
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
- Report `http.ListenAndServe` errors in the pprof demo instead of discarding them.
- Remove the obsolete Travis CI configuration, which still targeted Go 1.13.
- Update the README build badge to GitHub Actions.
- Fix grammar errors in the automatic issue and pull request comments.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #130
**Special notes for your reviewer**:
This PR addresses the confirmed actionable items from Issue #130.
The WebSocket jQuery dependency, `go.sum` version entries, v1 dependency locking, `OnError` cleanup, reconnect limits, and WebSocket close behavior were reviewed and do not require code changes.
The issue and pull request template suggestions were considered process improvements rather than required bug fixes and are intentionally excluded.
Validation completed successfully:
- `go test ./...`
- `go vet ./...`
- `git diff --check`
**Does this PR introduce a user-facing change?**:
No. Changes are limited to demo error logging, CI metadata, documentation badges, and automatic comment wording.
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix/quality [dubbo-getty]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks merged PR #144:
URL: https://github.com/apache/dubbo-getty/pull/144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix/quality [dubbo-getty]
Posted by "222twotwotwo (via GitHub)" <gi...@apache.org>.
222twotwotwo commented on code in PR #144:
URL: https://github.com/apache/dubbo-getty/pull/144#discussion_r3869286348
##########
.travis.yml:
##########
@@ -1,42 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-language: go
-
-os:
- - linux
-
-go:
- - "1.13"
-
-env:
- - GO111MODULE=on
-
-install: true
-
-script:
- # license-check
- - echo 'start license check'
- - sh before_validate_license.sh
- - chmod u+x /tmp/tools/license/license-header-checker
- - go fmt ./... && [[ -z `git status -s` ]]
- - /tmp/tools/license/license-header-checker -v -a -r -i vendor /tmp/tools/license/license.txt . go && [[ -z `git status -s` ]]
- - go mod vendor && go test $(go list ./... | grep -v vendor | grep -v demo) -coverprofile=coverage.txt -covermode=atomic
-
-after_success:
- - bash <(curl -s https://codecov.io/bash)
-
-notifications:
- webhooks: https://oapi.dingtalk.com/robot/send?access_token=75f4f1ec3868508aa89e5a5d6f9d342216809df3ebc8a78c8ae8722848e06166
Review Comment:
我这里无法在钉钉侧撤销或轮换token
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix/quality [dubbo-getty]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #144:
URL: https://github.com/apache/dubbo-getty/pull/144#discussion_r3868534126
##########
.travis.yml:
##########
@@ -1,42 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-language: go
-
-os:
- - linux
-
-go:
- - "1.13"
-
-env:
- - GO111MODULE=on
-
-install: true
-
-script:
- # license-check
- - echo 'start license check'
- - sh before_validate_license.sh
- - chmod u+x /tmp/tools/license/license-header-checker
- - go fmt ./... && [[ -z `git status -s` ]]
- - /tmp/tools/license/license-header-checker -v -a -r -i vendor /tmp/tools/license/license.txt . go && [[ -z `git status -s` ]]
- - go mod vendor && go test $(go list ./... | grep -v vendor | grep -v demo) -coverprofile=coverage.txt -covermode=atomic
-
-after_success:
- - bash <(curl -s https://codecov.io/bash)
-
-notifications:
- webhooks: https://oapi.dingtalk.com/robot/send?access_token=75f4f1ec3868508aa89e5a5d6f9d342216809df3ebc8a78c8ae8722848e06166
Review Comment:
[P1] 删除这个文件不会撤销这里暴露的钉钉 webhook 凭据；该 access_token 仍可从仓库历史（例如 9958f11 以及本 PR 的 base）读取。如果 token 尚未失效，合并后任何人仍能向对应机器人发消息。请先在钉钉侧撤销或轮换该 token，并给出已经失效的确认；历史重写可以另行评估，但不能把删文件本身当作凭据处置。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix/quality [dubbo-getty]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #144:
URL: https://github.com/apache/dubbo-getty/pull/144#discussion_r3871600822
##########
.travis.yml:
##########
@@ -1,42 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-language: go
-
-os:
- - linux
-
-go:
- - "1.13"
-
-env:
- - GO111MODULE=on
-
-install: true
-
-script:
- # license-check
- - echo 'start license check'
- - sh before_validate_license.sh
- - chmod u+x /tmp/tools/license/license-header-checker
- - go fmt ./... && [[ -z `git status -s` ]]
- - /tmp/tools/license/license-header-checker -v -a -r -i vendor /tmp/tools/license/license.txt . go && [[ -z `git status -s` ]]
- - go mod vendor && go test $(go list ./... | grep -v vendor | grep -v demo) -coverprofile=coverage.txt -covermode=atomic
-
-after_success:
- - bash <(curl -s https://codecov.io/bash)
-
-notifications:
- webhooks: https://oapi.dingtalk.com/robot/send?access_token=75f4f1ec3868508aa89e5a5d6f9d342216809df3ebc8a78c8ae8722848e06166
Review Comment:
这项不要求贡献者本人持有钉钉管理权限，但在旧 token 已失效之前风险仍然存在。请由拥有该机器人权限的 maintainer 撤销或轮换 token，并在本线程确认旧 token 已失效；确认前这条 P1 不能按“删掉配置文件”关闭。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org