You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2026/07/28 21:05:39 UTC
[PR] Fix documentation issues 1-12 [maven-compiler-plugin]
elharo opened a new pull request, #1094:
URL: https://github.com/apache/maven-compiler-plugin/pull/1094
## Changes
- index.md:53: Fixed 'describes' -> 'describe' (subject-verb agreement)
- index.md:61: Fixed 'non-javac compilers' -> 'non-javac compiler'
- sources.md:49,84: Fixed 'omited' -> 'omitted' (typo)
- sources.md:57,92: Added missing </build> closing tag in XML examples
- faq.fml:30: Fixed 'Modello generate' -> 'Modello generates' (grammar)
- compile-using-different-jdk.md:83: Fixed typo in path /java-11-openjdkk -> /java-11-openjdk
- site.xml:46: Renamed menu item 'Non-javac compilerIds' -> 'Compile Using a Non-Javac Compiler'
- site.xml:47: Renamed menu item 'Older projects with module-info' -> 'Java 9+ Projects with module-info'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation typos [maven-compiler-plugin]
Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux merged PR #1094:
URL: https://github.com/apache/maven-compiler-plugin/pull/1094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation typos [maven-compiler-plugin]
Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux commented on code in PR #1094:
URL: https://github.com/apache/maven-compiler-plugin/pull/1094#discussion_r3673359913
##########
src/site/site.xml:
##########
@@ -43,7 +43,7 @@ under the License.
<item name="Compile Using the --release javac Option" href="examples/set-compiler-release.html"/>
<item name="Compile Using Memory Allocation Enhancements" href="examples/compile-with-memory-enhancements.html"/>
<item name="Pass Compiler Arguments" href="examples/pass-compiler-arguments.html"/>
- <item name="Non-javac compilerIds" href="examples/non-javac-compilers.html"/>
+ <item name="Compile Using a Non-Javac Compiler" href="examples/non-javac-compilers.html"/>
<item name="Older projects with module-info" href="examples/module-info.html"/>
Review Comment:
Ignoring this Copilot suggestion since the referenced page is about both Java 8 and Java 9+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation typos [maven-compiler-plugin]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1094:
URL: https://github.com/apache/maven-compiler-plugin/pull/1094#discussion_r3669280755
##########
src/site/site.xml:
##########
@@ -43,7 +43,7 @@ under the License.
<item name="Compile Using the --release javac Option" href="examples/set-compiler-release.html"/>
<item name="Compile Using Memory Allocation Enhancements" href="examples/compile-with-memory-enhancements.html"/>
<item name="Pass Compiler Arguments" href="examples/pass-compiler-arguments.html"/>
- <item name="Non-javac compilerIds" href="examples/non-javac-compilers.html"/>
+ <item name="Compile Using a Non-Javac Compiler" href="examples/non-javac-compilers.html"/>
<item name="Older projects with module-info" href="examples/module-info.html"/>
Review Comment:
The PR description indicates the menu item for the module-info example should be renamed ("Older projects with module-info" -> "Java 9+ Projects with module-info"), but `site.xml` still uses the old label. This makes the site navigation inconsistent with the updated page title/link text in `index.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org