You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/06/21 16:49:29 UTC
Review Request 70924: Added registry operations for
DE/RE-ACTIVATE_AGENT calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70924/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
Bugs: MESOS-9814
https://issues.apache.org/jira/browse/MESOS-9814
Repository: mesos
Description
-------
This adds the associated registry operation and fields for the
DEACTIVATE_AGENT and REACTIVATE_AGENT master calls.
Like the DRAIN_AGENT call, the deactivation state also persists when
agents become unreachable/reachable, which is already handled by the
DRAIN_AGENT operation implementation.
Likewise, this feature is not downgrade compatible, and a minimum
capability is added when the deactivation feature is used.
If all draining or deactivated agents are reactivated, the minimum
capability is removed.
Diffs
-----
src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b
src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4
src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8
Diff: https://reviews.apache.org/r/70924/diff/1/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 70924: Added registry operations for
DE/RE-ACTIVATE_AGENT calls.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70924/#review216145
-----------------------------------------------------------
Bad review!
Reviews applied: [70924, 70923, 70922, 70911, 70910, 70822]
Error:
2019-06-25 23:45:34 URL:https://reviews.apache.org/r/70911/diff/raw/ [15579/15579] -> "70911.patch" [1]
error: patch failed: src/internal/devolve.hpp:55
error: src/internal/devolve.hpp: patch does not apply
- Mesos Reviewbot
On June 21, 2019, 4:49 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70924/
> -----------------------------------------------------------
>
> (Updated June 21, 2019, 4:49 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-9814
> https://issues.apache.org/jira/browse/MESOS-9814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the associated registry operation and fields for the
> DEACTIVATE_AGENT and REACTIVATE_AGENT master calls.
>
> Like the DRAIN_AGENT call, the deactivation state also persists when
> agents become unreachable/reachable, which is already handled by the
> DRAIN_AGENT operation implementation.
>
> Likewise, this feature is not downgrade compatible, and a minimum
> capability is added when the deactivation feature is used.
> If all draining or deactivated agents are reactivated, the minimum
> capability is removed.
>
>
> Diffs
> -----
>
> src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b
> src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4
> src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8
>
>
> Diff: https://reviews.apache.org/r/70924/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 70924: Added registry operations for
DE/RE-ACTIVATE_AGENT calls.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70924/#review216662
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On July 8, 2019, 6:39 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70924/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 6:39 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-9814
> https://issues.apache.org/jira/browse/MESOS-9814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the associated registry operation and fields for the
> DEACTIVATE_AGENT and REACTIVATE_AGENT master calls.
>
> Like the DRAIN_AGENT call, the deactivation state also persists when
> agents become unreachable/reachable, which is already handled by the
> DRAIN_AGENT operation implementation.
>
> Likewise, this feature is not downgrade compatible, and a minimum
> capability is added when the deactivation feature is used.
> If all draining or deactivated agents are reactivated, the minimum
> capability is removed.
>
>
> Diffs
> -----
>
> src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b
> src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4
> src/tests/registrar_tests.cpp 5f0de523705d124ddd2d21ad355f06633d68c141
>
>
> Diff: https://reviews.apache.org/r/70924/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 70924: Added registry operations for
DE/RE-ACTIVATE_AGENT calls.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70924/
-----------------------------------------------------------
(Updated July 8, 2019, 11:39 a.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
Changes
-------
Updated to use minimum capability helper.
Added extra conditionals to stop looping through agents earlier.
Bugs: MESOS-9814
https://issues.apache.org/jira/browse/MESOS-9814
Repository: mesos
Description
-------
This adds the associated registry operation and fields for the
DEACTIVATE_AGENT and REACTIVATE_AGENT master calls.
Like the DRAIN_AGENT call, the deactivation state also persists when
agents become unreachable/reachable, which is already handled by the
DRAIN_AGENT operation implementation.
Likewise, this feature is not downgrade compatible, and a minimum
capability is added when the deactivation feature is used.
If all draining or deactivated agents are reactivated, the minimum
capability is removed.
Diffs (updated)
-----
src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b
src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4
src/tests/registrar_tests.cpp 5f0de523705d124ddd2d21ad355f06633d68c141
Diff: https://reviews.apache.org/r/70924/diff/3/
Changes: https://reviews.apache.org/r/70924/diff/2-3/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 70924: Added registry operations for
DE/RE-ACTIVATE_AGENT calls.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70924/
-----------------------------------------------------------
(Updated June 26, 2019, 1:46 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
Changes
-------
Rebased on newer protos and some changes to commits earlier.
Bugs: MESOS-9814
https://issues.apache.org/jira/browse/MESOS-9814
Repository: mesos
Description
-------
This adds the associated registry operation and fields for the
DEACTIVATE_AGENT and REACTIVATE_AGENT master calls.
Like the DRAIN_AGENT call, the deactivation state also persists when
agents become unreachable/reachable, which is already handled by the
DRAIN_AGENT operation implementation.
Likewise, this feature is not downgrade compatible, and a minimum
capability is added when the deactivation feature is used.
If all draining or deactivated agents are reactivated, the minimum
capability is removed.
Diffs (updated)
-----
src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b
src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4
src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8
Diff: https://reviews.apache.org/r/70924/diff/2/
Changes: https://reviews.apache.org/r/70924/diff/1-2/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 70924: Added registry operations for
DE/RE-ACTIVATE_AGENT calls.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70924/#review216070
-----------------------------------------------------------
Fix it, then Ship it!
src/master/registry_operations.cpp
Lines 527 (patched)
<https://reviews.apache.org/r/70924/#comment303055>
Maybe:
```
if (moreThanOneDeactivated) {
break;
}
continue;
```
- Greg Mann
On June 21, 2019, 4:49 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70924/
> -----------------------------------------------------------
>
> (Updated June 21, 2019, 4:49 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-9814
> https://issues.apache.org/jira/browse/MESOS-9814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the associated registry operation and fields for the
> DEACTIVATE_AGENT and REACTIVATE_AGENT master calls.
>
> Like the DRAIN_AGENT call, the deactivation state also persists when
> agents become unreachable/reachable, which is already handled by the
> DRAIN_AGENT operation implementation.
>
> Likewise, this feature is not downgrade compatible, and a minimum
> capability is added when the deactivation feature is used.
> If all draining or deactivated agents are reactivated, the minimum
> capability is removed.
>
>
> Diffs
> -----
>
> src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b
> src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4
> src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8
>
>
> Diff: https://reviews.apache.org/r/70924/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>