[GitHub] [hive] marton-bod commented on a diff in pull request #3287: HIVE-26228: Implement Iceberg table rollback feature

[GitBox <gi...@apache.org>]

marton-bod commented on code in PR #3287:
URL: https://github.com/apache/hive/pull/3287#discussion_r873765452


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -425,6 +425,15 @@ public void commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
         case SETPARTITIONSPEC:
           IcebergTableUtil.updateSpec(conf, icebergTable);
           break;
+        case ROLLBACK:
+          LOG.info("Executing rollback operation on iceberg table. If you would like to revert rollback you could " +

Review Comment:
   I might be wrong, but I thought rollback would just resets the table's version to point to a previous version, like `git reset`, and does not create a new snapshot



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org