[GitHub] [fineract] vorburger commented on issue #755: FINERACT-826 Remove unused getTimeZone

[GitBox <gi...@apache.org>]

vorburger commented on issue #755: FINERACT-826 Remove unused getTimeZone
URL: https://github.com/apache/fineract/pull/755#issuecomment-612828128
 
 
   @percyashu I guess the IT failures here are unrelated to this change, see [FINERACT-885](https://jira.apache.org/jira/browse/FINERACT-885). Just keep trying once a day or so, until we have a green build? I know it's stupid.. if you can dig more into FINERACT-885, perhaps try fixing [FINERACT-723](https://jira.apache.org/jira/browse/FINERACT-723), that would be cool! 
   
   > I also want to check if very tenant is guaranteed to always have a TZ.
   > @vorburger seems it falls dependent on the OS / JVM TZ if tenant TZ is null.
   
   if it's not mandatory (`NON NULL`) in the DB, then you can't be sure, right? It would break backwards compatibility for any existing installations out there, agreed? The only thing we (you) could do if you want to fix this is to make a Flyway migration script that sets it to required? Then anyone upgrading would fail, and would be forced to set a TZ for each of their Tenants, if they don't already have one. Then you could make this code assume there always is one, and throw a (clear... include reference to a JIRA!) exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services