[GitHub] [servicecomb-pack] zhfeng commented on a change in pull request #517: SCB-1386 Introduce sendingSagaEnd attribute to SagaStart and Compensable annotations

[GitBox <gi...@apache.org>]

zhfeng commented on a change in pull request #517: SCB-1386 Introduce sendingSagaEnd attribute to SagaStart and Compensable annotations
URL: https://github.com/apache/servicecomb-pack/pull/517#discussion_r308032012
 
 

 ##########
 File path: omega/omega-context/src/main/java/org/apache/servicecomb/pack/omega/context/annotations/SagaStart.java
 ##########
 @@ -37,4 +37,11 @@
    * @return
    */
   int timeout() default 0;
+
+  /**
+   * Sending out SagaEnd event to Alpha once the SagaStart annotated method is finished without any error.
+   * Default value is true, which means Omega sends out the SagaEnd event to Alpha once the annotated method is finished.
+   * Value is false, which means Omega never sends out the SagaEnd event to Alpha once the annotated method is finished.
+   */
+  boolean sendingSagaEnd() default true;
 
 Review comment:
   I prefer to use the "delay" attribute name. It could be clear that the saga transaction will be closed later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services