[GitHub] [incubator-tvm] soiferj commented on a change in pull request #4258: [WIP][TVM] Bring Your Own Codegen to TVM

[GitBox <gi...@apache.org>]

soiferj commented on a change in pull request #4258: [WIP][TVM] Bring Your Own Codegen to TVM
URL: https://github.com/apache/incubator-tvm/pull/4258#discussion_r343169996
 
 

 ##########
 File path: cmake/config.cmake
 ##########
 @@ -143,6 +143,12 @@ set(USE_ROCBLAS OFF)
 # Whether use contrib sort
 set(USE_SORT ON)
 
+# Whether use contrib extern (use ";" to separate multiple externs)
+# Available externs:
+#   gcc
+#   dnnl
+set(USE_EXTERN none)
 
 Review comment:
   Given the number of external compilers and runtimes we may have, I think it's better for each one to have its own field in config.cmake. For example, `USE_GCC` or `USE_DNNL`. With this, we can be more flexible with our options for finding the compiler / runtime. For example, `USE_GCC=ON` vs `USE_GCC=<path to gcc>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services