You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "Vladsz83 (via GitHub)" <gi...@apache.org> on 2026/04/28 09:42:41 UTC
[PR] IGNITE-28512 Message serializer for partition key and VisorTaskResult [ignite]
Vladsz83 opened a new pull request, #13084:
URL: https://github.com/apache/ignite/pull/13084
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "Vladsz83 (via GitHub)" <gi...@apache.org>.
Vladsz83 commented on code in PR #13084:
URL: https://github.com/apache/ignite/pull/13084#discussion_r3201169218
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java:
##########
@@ -686,19 +703,28 @@ public TcpDiscoveryNode clientReconnectNode(Map<String, Object> nodeAttrs) {
}
/**
- * IMPORTANT!
- * Only purpose of this constructor is creating node which contains necessary data to store on disc only
- * @param node to copy data from
+ * Downcasts type of map's key value.
+ *
+ * @param <PK> Map parent key type.
+ * @param <CK> Child key type.
+ * @param <V> Map value type.
+ * @param m Initial collections map.
+ * @return Resulting map.
*/
- public TcpDiscoveryNode(ClusterNode node) {
- this.id = node.id();
- this.consistentId = node.consistentId();
- this.addrs = node.addresses();
- this.hostNames = node.hostNames();
- this.order = node.order();
- this.ver = node.version();
- this.clientRouterNodeId = node.isClient() ? node.id() : null;
-
- attrs = Collections.singletonMap(ATTR_NODE_CONSISTENT_ID, consistentId);
+ public static <PK, CK extends PK, V> Map<CK, V> downcast(Map<PK, V> m) {
Review Comment:
It is only about TcoDiscoveryNode and ZookeeperNode which might be removed in future with zookeper discovery removal. With zookeper removal, the upcast and downcast would be even rarer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #13084:
URL: https://github.com/apache/ignite/pull/13084#discussion_r3200720650
##########
modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java:
##########
@@ -17,24 +17,28 @@
package org.apache.ignite.internal.visor;
+import java.io.Serializable;
import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.managers.communication.ErrorMessage;
import org.jetbrains.annotations.Nullable;
/**
* Management task result.
*/
-public class VisorTaskResult<R> extends IgniteDataTransferObject {
+public class VisorTaskResult<R> implements Serializable {
Review Comment:
Why serializable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for partition key and VisorTaskResult [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13084:
URL: https://github.com/apache/ignite/pull/13084#issuecomment-4346036466
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyDumpResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckPartitionHashesResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandlerResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/PartitionHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "Vladsz83 (via GitHub)" <gi...@apache.org>.
Vladsz83 commented on code in PR #13084:
URL: https://github.com/apache/ignite/pull/13084#discussion_r3201158149
##########
modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java:
##########
@@ -17,24 +17,28 @@
package org.apache.ignite.internal.visor;
+import java.io.Serializable;
import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.managers.communication.ErrorMessage;
import org.jetbrains.annotations.Nullable;
/**
* Management task result.
*/
-public class VisorTaskResult<R> extends IgniteDataTransferObject {
+public class VisorTaskResult<R> implements Serializable {
Review Comment:
Because the thin client protocol doesnt support messages. And the realisation is far beyond this ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for partition key and VisorTaskResult [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13084:
URL: https://github.com/apache/ignite/pull/13084#issuecomment-4359036399
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyDumpResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IncrementalSnapshotVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckPartitionHashesResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandlerResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/PartitionHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #13084:
URL: https://github.com/apache/ignite/pull/13084#discussion_r3200748727
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java:
##########
@@ -686,19 +703,28 @@ public TcpDiscoveryNode clientReconnectNode(Map<String, Object> nodeAttrs) {
}
/**
- * IMPORTANT!
- * Only purpose of this constructor is creating node which contains necessary data to store on disc only
- * @param node to copy data from
+ * Downcasts type of map's key value.
+ *
+ * @param <PK> Map parent key type.
+ * @param <CK> Child key type.
+ * @param <V> Map value type.
+ * @param m Initial collections map.
+ * @return Resulting map.
*/
- public TcpDiscoveryNode(ClusterNode node) {
- this.id = node.id();
- this.consistentId = node.consistentId();
- this.addrs = node.addresses();
- this.hostNames = node.hostNames();
- this.order = node.order();
- this.ver = node.version();
- this.clientRouterNodeId = node.isClient() ? node.id() : null;
-
- attrs = Collections.singletonMap(ATTR_NODE_CONSISTENT_ID, consistentId);
+ public static <PK, CK extends PK, V> Map<CK, V> downcast(Map<PK, V> m) {
Review Comment:
We already have several downcast and upcast methods in ServerImpl, TcpDiscoveryImpl. May be we should move them to IgniteUtils and merge (if possible).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #13084:
URL: https://github.com/apache/ignite/pull/13084#discussion_r3201200099
##########
modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java:
##########
@@ -17,24 +17,28 @@
package org.apache.ignite.internal.visor;
+import java.io.Serializable;
import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.managers.communication.ErrorMessage;
import org.jetbrains.annotations.Nullable;
/**
* Management task result.
*/
-public class VisorTaskResult<R> extends IgniteDataTransferObject {
+public class VisorTaskResult<R> implements Serializable {
Review Comment:
Should we remove `@Order` from fields then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for partition key and VisorTaskResult [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13084:
URL: https://github.com/apache/ignite/pull/13084#issuecomment-4359716892
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyDumpResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IncrementalSnapshotVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckPartitionHashesResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandlerResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/PartitionHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #13084:
URL: https://github.com/apache/ignite/pull/13084#discussion_r3200720650
##########
modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java:
##########
@@ -17,24 +17,28 @@
package org.apache.ignite.internal.visor;
+import java.io.Serializable;
import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.managers.communication.ErrorMessage;
import org.jetbrains.annotations.Nullable;
/**
* Management task result.
*/
-public class VisorTaskResult<R> extends IgniteDataTransferObject {
+public class VisorTaskResult<R> implements Serializable {
Review Comment:
Why Serializable, not Message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for partition key and VisorTaskResult [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13084:
URL: https://github.com/apache/ignite/pull/13084#issuecomment-4334095815
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyDumpResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckPartitionHashesResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandlerResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/PartitionHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for partition key and VisorTaskResult [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13084:
URL: https://github.com/apache/ignite/pull/13084#issuecomment-4360423077
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyDumpResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IncrementalSnapshotVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckPartitionHashesResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandlerResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/PartitionHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #13084:
URL: https://github.com/apache/ignite/pull/13084#discussion_r3201200099
##########
modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java:
##########
@@ -17,24 +17,28 @@
package org.apache.ignite.internal.visor;
+import java.io.Serializable;
import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.managers.communication.ErrorMessage;
import org.jetbrains.annotations.Nullable;
/**
* Management task result.
*/
-public class VisorTaskResult<R> extends IgniteDataTransferObject {
+public class VisorTaskResult<R> implements Serializable {
Review Comment:
Should we remove `@Order` then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "Vladsz83 (via GitHub)" <gi...@apache.org>.
Vladsz83 closed pull request #13084: IGNITE-28512 Message serializer for PartitionKey
URL: https://github.com/apache/ignite/pull/13084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13084:
URL: https://github.com/apache/ignite/pull/13084#issuecomment-4396948121
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyDumpResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IncrementalSnapshotVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckPartitionHashesResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandlerResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/PartitionHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for PartitionKey [ignite]
Posted by "Vladsz83 (via GitHub)" <gi...@apache.org>.
Vladsz83 commented on code in PR #13084:
URL: https://github.com/apache/ignite/pull/13084#discussion_r3201240783
##########
modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java:
##########
@@ -17,24 +17,28 @@
package org.apache.ignite.internal.visor;
+import java.io.Serializable;
import org.apache.ignite.internal.Order;
-import org.apache.ignite.internal.dto.IgniteDataTransferObject;
+import org.apache.ignite.internal.managers.communication.ErrorMessage;
import org.jetbrains.annotations.Nullable;
/**
* Management task result.
*/
-public class VisorTaskResult<R> extends IgniteDataTransferObject {
+public class VisorTaskResult<R> implements Serializable {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for partition key and VisorTaskResult [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13084:
URL: https://github.com/apache/ignite/pull/13084#issuecomment-4365769651
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyDumpResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IncrementalSnapshotVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckPartitionHashesResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandlerResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/PartitionHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28512 Message serializer for partition key and VisorTaskResult [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13084:
URL: https://github.com/apache/ignite/pull/13084#issuecomment-4334108797
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyDumpResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/management/cache/IdleVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckPartitionHashesResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandlerResponse.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyResult.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/PartitionHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/TransactionsHashRecord.java`
- `modules/core/src/main/java/org/apache/ignite/internal/visor/VisorTaskResult.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org