You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/01 08:58:13 UTC

[GitHub] [kafka] showuon commented on pull request #9777: KAFKA-7940: wait until we've got the expected partition size

showuon commented on pull request #9777:
URL: https://github.com/apache/kafka/pull/9777#issuecomment-770691251


   @hachikuji , thanks for the comments. I've updated:
   1. rename the method:
   `waitUntilMetadataIsPropagatedWithExpectedSize` -> `waitForAllPartitionMetadata`
   `waitUntilMetadataIsPropagated` -> `waitForPartitionMetadata`
   2. return the partition metadata for `waitForAllPartitionMetadata` and `waitForPartitionMetadata`.
   3. skip the calls to `waitUntilMetadataIsPropagated` and `waitUntilLeaderIsElectedOrChanged`, get the info from the returned partition metadata
   4. Use `server.metadataCache` directly instead of `server.dataPlaneRequestProcessor.metadataCache`
   
   Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org