You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/09 16:46:43 UTC

[GitHub] [superset] mistercrunch commented on pull request #15055: feat: spinner for imports

mistercrunch commented on pull request #15055:
URL: https://github.com/apache/superset/pull/15055#issuecomment-857861774


   Wondering why we're hiding the context while the spinner is active context? We have a fair amount of "modal resizing" in the product currently (as dynamic content changes the height of the context) and it generally looks jittery. Keeping the context would prevent that.
   
   Side note: can we re-style the button too? I know these file buttons are funky to style sometimes, but if we take over with an antd component maybe we can just disable the button while the spinner is active?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org