You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2015/09/15 09:08:36 UTC

Review Request 38394: FALCON-1449 Move getEntityProperties to EntityUtil

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38394/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1449
    https://issues.apache.org/jira/browse/FALCON-1449


Repository: falcon-git


Description
-------

Refactoring of OozieWorkflowEngine. Moved getEntityProperties to EntityUtil.


Diffs
-----

  common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008 
  common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d 
  oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java 9a6b14c 
  oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java f7193a3 
  oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationCoordinatorBuilder.java db08d60 
  oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java ce9ef9a 
  oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java d6d42e1 
  oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java ac436ca 

Diff: https://reviews.apache.org/r/38394/diff/


Testing
-------

Added some unit tests cases as well as part of the refactoring.


Thanks,

Ajay Yadava


Re: Review Request 38394: FALCON-1449 Move getEntityProperties to EntityUtil

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38394/#review99003
-----------------------------------------------------------

Ship it!


Ship It!

- Pallavi Rao


On Sept. 15, 2015, 7:08 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38394/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 7:08 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1449
>     https://issues.apache.org/jira/browse/FALCON-1449
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Refactoring of OozieWorkflowEngine. Moved getEntityProperties to EntityUtil.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008 
>   common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java 9a6b14c 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java f7193a3 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationCoordinatorBuilder.java db08d60 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java ce9ef9a 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java d6d42e1 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java ac436ca 
> 
> Diff: https://reviews.apache.org/r/38394/diff/
> 
> 
> Testing
> -------
> 
> Added some unit tests cases as well as part of the refactoring.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>