You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/01 15:06:04 UTC

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2930: tools/version.sh: If the version is not available, use 0.0.0

hartmannathan commented on pull request #2930:
URL: https://github.com/apache/incubator-nuttx/pull/2930#issuecomment-788018984


   I don't think we should add a new CONFIG_ for this, because then people will have to remember to set it, or make a mistake and set it incorrectly.
   
   > Another idea that has been suggested before is to include the latest `.version` file, under a different name, with the repo and update it each release. Then `version.sh` will use that as a last resort.
   
   Instead of a file, put the value directly into `version.sh` instead of a dummy value? And forget my earlier idea of a new command option, but output a "warning: version cannot be found, using default value of x.x.x"?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org