You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "stayrascal (via GitHub)" <gi...@apache.org> on 2024/11/26 01:37:14 UTC

[PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

stayrascal opened a new pull request, #3760:
URL: https://github.com/apache/flink-cdc/pull/3760

   set waitCompaction with true during prepare common of PaimonWriter to avoid CME problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #3760:
URL: https://github.com/apache/flink-cdc/pull/3760#issuecomment-2499506616

   Please add  this option to the test in https://github.com/apache/flink-cdc/blob/c969957f027dc308791b2ddbff50413122053d70/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonSinkITCase.java#L151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #3760:
URL: https://github.com/apache/flink-cdc/pull/3760#issuecomment-2503048937

   The failure of CI is case of postgres connector, which is unrelated to the changes, I think that it didn't block this pr, we can trace it in another issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #3760:
URL: https://github.com/apache/flink-cdc/pull/3760#issuecomment-2519768678

   @ruanhang1993 @leonardBang  Could you please take a look at this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

Posted by "stayrascal (via GitHub)" <gi...@apache.org>.
stayrascal commented on PR #3760:
URL: https://github.com/apache/flink-cdc/pull/3760#issuecomment-2519652472

   > The failure of CI is case of postgres connector, which is unrelated to the changes, I think that it didn't block this pr, we can trace it in another issue.
   
   ok, so what can I do and then the PR can be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

Posted by "stayrascal (via GitHub)" <gi...@apache.org>.
stayrascal commented on PR #3760:
URL: https://github.com/apache/flink-cdc/pull/3760#issuecomment-2556104968

   Hi @lvyanquan @leonardBang Thanks for review this PR, may I check what else I can do to merge this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on PR #3760:
URL: https://github.com/apache/flink-cdc/pull/3760#issuecomment-2558324584

   @stayrascal Could you check the failed CI tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang merged PR #3760:
URL: https://github.com/apache/flink-cdc/pull/3760


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

Posted by "stayrascal (via GitHub)" <gi...@apache.org>.
stayrascal commented on PR #3760:
URL: https://github.com/apache/flink-cdc/pull/3760#issuecomment-2564966211

   > @stayrascal Could you check the failed CI tests?
   
   Sorry for reply late, it looks that all CI cases are passed now. Previously the postgress connector test case failed but it's not related to this PR as lvyanquan mentioned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36790][cdc-connector][paimon] set waitCompaction with true dur… [flink-cdc]

Posted by "stayrascal (via GitHub)" <gi...@apache.org>.
stayrascal commented on PR #3760:
URL: https://github.com/apache/flink-cdc/pull/3760#issuecomment-2502468245

   > +1, good catch!
   
   Thanks for reviewing, do you know how to rerun the CI since one pipeline failed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org