You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/04 10:37:40 UTC
Re: Review Request 39450: Quota: Added hierarchical
allocator-specific tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 9:37 a.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu, and Qian Zhang.
Bugs: MESOS-3984
https://issues.apache.org/jira/browse/MESOS-3984
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/39450/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 39450: Quota: Added hierarchical
allocator-specific tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/#review108971
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40961, 40821, 39450]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 4, 2015, 10:09 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39450/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 10:09 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu, and Qian Zhang.
>
>
> Bugs: MESOS-3984
> https://issues.apache.org/jira/browse/MESOS-3984
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp a45b3dd0a8237fdd080536cb9ab600e71ad939d3
>
> Diff: https://reviews.apache.org/r/39450/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39450: Quota: Added hierarchical
allocator-specific tests.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/#review109012
-----------------------------------------------------------
Ship it!
Touched up some comments before committing.
src/tests/hierarchical_allocator_tests.cpp (line 183)
<https://reviews.apache.org/r/39450/#comment168424>
static?
- Joris Van Remoortere
On Dec. 4, 2015, 10:09 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39450/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 10:09 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu, and Qian Zhang.
>
>
> Bugs: MESOS-3984
> https://issues.apache.org/jira/browse/MESOS-3984
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp a45b3dd0a8237fdd080536cb9ab600e71ad939d3
>
> Diff: https://reviews.apache.org/r/39450/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39450: Quota: Added hierarchical
allocator-specific tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 10:09 a.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu, and Qian Zhang.
Changes
-------
Rebased.
Bugs: MESOS-3984
https://issues.apache.org/jira/browse/MESOS-3984
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/39450/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov