You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2013/10/10 02:30:07 UTC
Review Request 14564: SENTRY-42: Create sentry-provider-policy-search module
- RoleValidators, Permissions, Authorizables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14564/
-----------------------------------------------------------
Review request for sentry, Brock Noland and Shreepadma Venugopalan.
Bugs: SENTRY-42
https://issues.apache.org/jira/browse/SENTRY-42
Repository: sentry
Description
-------
This should be a subtask of SENTRY-35, but you can't create subtasks of subtasks as far as I know. I'm trying to break these JIRAs into more digestable pieces.
Only includes the RoleValidators, Permissions, and Authorizables for the sentry-provider-policy-search module. Still need the AuthorizationProviders and PolicyEngine to complete the module.
Diffs
-----
pom.xml d266e26
sentry-dist/pom.xml e9fbdfd
sentry-dist/src/main/assembly/src.xml 2bd52e7
sentry-provider/pom.xml 0eaabbd
sentry-provider/sentry-provider-policy-search/pom.xml PRE-CREATION
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/AbstractSearchRoleValidator.java PRE-CREATION
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/CollectionRequiredInRole.java PRE-CREATION
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SearchModelAuthorizables.java PRE-CREATION
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SearchWildcardPermission.java PRE-CREATION
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestCollectionRequiredInRole.java PRE-CREATION
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchModelAuthorizables.java PRE-CREATION
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchWildcardPermission.java PRE-CREATION
Diff: https://reviews.apache.org/r/14564/diff/
Testing
-------
Ran the unit tests, not the e2e tests yet.
Thanks,
Gregory Chanan
Re: Review Request 14564: SENTRY-42: Create sentry-provider-policy-search
module - RoleValidators, Permissions, Authorizables
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14564/#review26847
-----------------------------------------------------------
Ship it!
LGTM
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/CollectionRequiredInRole.java
<https://reviews.apache.org/r/14564/#comment52204>
In the future we should make this more non-db specific.
- Brock Noland
On Oct. 10, 2013, 12:30 a.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14564/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2013, 12:30 a.m.)
>
>
> Review request for sentry, Brock Noland and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-42
> https://issues.apache.org/jira/browse/SENTRY-42
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This should be a subtask of SENTRY-35, but you can't create subtasks of subtasks as far as I know. I'm trying to break these JIRAs into more digestable pieces.
>
> Only includes the RoleValidators, Permissions, and Authorizables for the sentry-provider-policy-search module. Still need the AuthorizationProviders and PolicyEngine to complete the module.
>
>
> Diffs
> -----
>
> pom.xml d266e26
> sentry-dist/pom.xml e9fbdfd
> sentry-dist/src/main/assembly/src.xml 2bd52e7
> sentry-provider/pom.xml 0eaabbd
> sentry-provider/sentry-provider-policy-search/pom.xml PRE-CREATION
> sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/AbstractSearchRoleValidator.java PRE-CREATION
> sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/CollectionRequiredInRole.java PRE-CREATION
> sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SearchModelAuthorizables.java PRE-CREATION
> sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SearchWildcardPermission.java PRE-CREATION
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestCollectionRequiredInRole.java PRE-CREATION
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchModelAuthorizables.java PRE-CREATION
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchWildcardPermission.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14564/diff/
>
>
> Testing
> -------
>
> Ran the unit tests, not the e2e tests yet.
>
>
> Thanks,
>
> Gregory Chanan
>
>