You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2017/12/06 16:40:37 UTC
[GitHub] nifi pull request #2323: NIFI-4671: Ensure that Avro Schemas that are create...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2323
NIFI-4671: Ensure that Avro Schemas that are created properly denote …
…fields as being nullable iff the schemas says they are, for non-top-level fields
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4671
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2323
----
commit 3c43fc89a97a9770e85825f8533f09388e2c3a59
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-12-06T16:40:05Z
NIFI-4671: Ensure that Avro Schemas that are created properly denote fields as being nullable iff the schemas says they are, for non-top-level fields
----
---
[GitHub] nifi issue #2323: NIFI-4671: Ensure that Avro Schemas that are created prope...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2323
@mmucha-redhat this has been merged to master, so it will be available in the next minor release (1.5.0).
---
[GitHub] nifi pull request #2323: NIFI-4671: Ensure that Avro Schemas that are create...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 closed the pull request at:
https://github.com/apache/nifi/pull/2323
---
[GitHub] nifi issue #2323: NIFI-4671: Ensure that Avro Schemas that are created prope...
Posted by mmucha-redhat <gi...@git.apache.org>.
Github user mmucha-redhat commented on the issue:
https://github.com/apache/nifi/pull/2323
In which nifi version can we expect this to be merged?
---