[jira] [Commented] (JCR-3229) FileRevision should have a flag to control whether to sync the file on every write.

["Dominique Pfister (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202417#comment-13202417 ] 

Dominique Pfister commented on JCR-3229:
----------------------------------------

Hi Mete,

Thanks for providing a patch. I noticed that you changed both FileJournal's and DatabaseJournal's revision.log to not sync after writing (opposed to the current state where they sync after every write), which might result in information loss if that cluster node crashes before the file system will eventually write changes back to disk. Don't you think this might be problematic?

Kind regards
Dominique
                
> FileRevision should have a flag to control whether to sync the file on every write.
> -----------------------------------------------------------------------------------
>
>                 Key: JCR-3229
>                 URL: https://issues.apache.org/jira/browse/JCR-3229
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Mete Atamel
>            Priority: Minor
>              Labels: performance
>             Fix For: 2.5
>
>         Attachments: 3229.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> FileRevision class syncs the underlying revision.log file it uses on every write which could be a performance problem. Add a boolean flag to control whether to sync the file on every write.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira