You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/03/24 08:17:18 UTC
[GitHub] [skywalking-kubernetes] kezhenxu94 opened a new pull request, #115: Add `cert-manager` sub-chart as quick start
kezhenxu94 opened a new pull request, #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115
Also unify the feature switch name to `enabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #115: Add `cert-manager` sub-chart as quick start
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115#issuecomment-1482511929
> > Can you elaborate? How would that tools chart work and what does it do?
>
> Mainly, I want to deploy other things that oap needs with `one-click` (easy).
Isn't that what the subchart does?
> Later, we can make our showcases into charts.
I'm currently migrating showcase to Chart, and this patch is one of the things needed.
> For example, otel may need opentelemetry-collector charts and ksm charts. But if oap dependent on these charts, it feels inappropriate.
Yes, so we should put these dependencies in showcase.
In my opinion the Helm Chart dependencies should be something that MUST have in order to make the main Chart work, though it can be pre-installed and we would use `condition` for that dependency. But optional features (like OTEL) should not add dependencies into Chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #115: Add `cert-manager` sub-chart as quick start
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115#issuecomment-1482477317
Let the tools chart do things that are not directly related to the oap or operator. I don't know if it's good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #115: Add `cert-manager` sub-chart as quick start
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115#issuecomment-1482444264
> Hi, Could we make a tools chart to do these things, tools chart to dependent on our oap, operator chart. @kezhenxu94
Can you elaborate? How would that tools chart work and what does it do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #115: Add `cert-manager` sub-chart as quick start
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115#issuecomment-1482468915
> Can you elaborate? How would that tools chart work and what does it do?
Mainly, I want to deploy other things that oap needs with `one-click` (easy).
Later, we can make our showcases into charts. For example, otel may need opentelemetry-collector charts and ksm charts. But if oap dependent on these charts, it feels inappropriate.
I'm still not very clear what should be put in the oap or operator chart, what should be put in the tools chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on a diff in pull request #115: Add `cert-manager` sub-chart as quick start
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on code in PR #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115#discussion_r1147261643
##########
chart/operator/templates/cert.yaml:
##########
@@ -13,12 +13,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-{{- if .Values.webhook.enable }}
+{{- if .Values.webhook.enabled }}
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: {{ include "operator.fullname" . }}-serving-cert
namespace: {{ .Release.Namespace }}
+ annotations:
+ "helm.sh/hook": post-install,post-upgrade
+ "helm.sh/hook-weight": "1"
Review Comment:
Issuer
Certificate
Do different weights to distinguish the execution order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #115: Add `cert-manager` sub-chart as quick start
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115#issuecomment-1482442931
Hi, Could we make a tools chart to do these things, tools chart to dependent on our oap, operator chart. @kezhenxu94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 merged pull request #115: Add `cert-manager` sub-chart as quick start
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #115: Add `cert-manager` sub-chart as quick start
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115#discussion_r1147265087
##########
chart/operator/templates/cert.yaml:
##########
@@ -13,12 +13,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-{{- if .Values.webhook.enable }}
+{{- if .Values.webhook.enabled }}
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: {{ include "operator.fullname" . }}-serving-cert
namespace: {{ .Release.Namespace }}
+ annotations:
+ "helm.sh/hook": post-install,post-upgrade
+ "helm.sh/hook-weight": "1"
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org