You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "FangYongs (via GitHub)" <gi...@apache.org> on 2023/06/27 15:03:06 UTC
[GitHub] [flink] FangYongs opened a new pull request, #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
FangYongs opened a new pull request, #22882:
URL: https://github.com/apache/flink/pull/22882
## What is the purpose of the change
Change log level from error to debug for jdbc e2e test
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
- The S3 file system connector: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #22882:
URL: https://github.com/apache/flink/pull/22882#issuecomment-1610400379
@libenchao I turn off the error log in handler and fetcher, please help to review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1244874193
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,10 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
+ if (log.isDebugEnabled()) {
Review Comment:
I wonder why we should switch to debug for a generic class which is not jdbc driver only related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1246421258
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,10 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
+ if (log.isDebugEnabled()) {
Review Comment:
Thanks for addressing comment
I guess I'm not the best person to review here since I 'm not aware of this Flink area enough...
May be another pair of eyes would be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on a diff in pull request #22882: [FLINK-32370][runtime] Revert print error log in AbstractHandler and skip check exceptions in jdbc driver e2e tests which will check the test results itself
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1248422378
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,12 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
- log.error("Unhandled exception.", throwable);
- }
+ log.error("Unhandled exception.", throwable);
Review Comment:
The original here is just `log.error("Unhandled exception.", throwable)` before we want to fix FLIP-32370, so it's right here to delete the `if ... else ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #22882:
URL: https://github.com/apache/flink/pull/22882#issuecomment-1614089480
Thanks @zentol , sorry for my insufficient understanding of e2e test and it's cool about your suggestion 👍. I have updated this PR to ignore checking exceptions in jdbc driver e2e test which will check the results in the test itself, could you have a look again? Thanks so mush
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on a diff in pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1246045200
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,10 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
+ if (log.isDebugEnabled()) {
Review Comment:
Thanks @snuyanzin , good point! I agree with you that we should deal the exception in `ClientCoordinationsHandler` which is used to return collected results instead of the generic `AbstractHandler`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on a diff in pull request #22882: [FLINK-32370][runtime] Revert print error log in AbstractHandler and skip check exceptions in jdbc driver e2e tests which will check the test results itself
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1248421262
##########
flink-end-to-end-tests/run-nightly-tests.sh:
##########
@@ -185,7 +185,7 @@ function run_group_2 {
run_test "Batch SQL end-to-end test using hybrid selective shuffle" "$END_TO_END_DIR/test-scripts/test_batch_sql.sh hybrid_selective"
run_test "Streaming SQL end-to-end test using planner loader" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh" "skip_check_exceptions"
run_test "Streaming SQL end-to-end test using planner with Scala version" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh scala-planner" "skip_check_exceptions"
- run_test "Sql Jdbc Driver end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh"
+ run_test "Sql Jdbc Driver end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh skip_check_exceptions"
Review Comment:
@zentol Yes, the test_sql_jdbc_driver will validate its query results in another files, all exceptions and error logs during this process are mainly for future issue analysis and are acceptable if the query results are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on a diff in pull request #22882: [FLINK-32370][runtime] Revert print error log in AbstractHandler and skip check exceptions in jdbc driver e2e tests which will check the test results itself
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1248421262
##########
flink-end-to-end-tests/run-nightly-tests.sh:
##########
@@ -185,7 +185,7 @@ function run_group_2 {
run_test "Batch SQL end-to-end test using hybrid selective shuffle" "$END_TO_END_DIR/test-scripts/test_batch_sql.sh hybrid_selective"
run_test "Streaming SQL end-to-end test using planner loader" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh" "skip_check_exceptions"
run_test "Streaming SQL end-to-end test using planner with Scala version" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh scala-planner" "skip_check_exceptions"
- run_test "Sql Jdbc Driver end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh"
+ run_test "Sql Jdbc Driver end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh skip_check_exceptions"
Review Comment:
@zentol Yes, the test_sql_jdbc_driver will validate its query results in another files, all exceptions and error logs during this process are mainly for future issue analysis and are acceptable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1246482509
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/coordination/ClientCoordinationHandler.java:
##########
@@ -77,21 +77,29 @@ protected CompletableFuture<ClientCoordinationResponseBody> handleRequest(
OperatorID operatorId = request.getPathParameter(OperatorIDPathParameter.class);
SerializedValue<CoordinationRequest> serializedRequest =
request.getRequestBody().getSerializedCoordinationRequest();
- CompletableFuture<CoordinationResponse> responseFuture =
- gateway.deliverCoordinationRequestToCoordinator(
- jobId, operatorId, serializedRequest, timeout);
- return responseFuture.thenApply(
- coordinationResponse -> {
- try {
- return new ClientCoordinationResponseBody(
- new SerializedValue<>(coordinationResponse));
- } catch (IOException e) {
- throw new CompletionException(
- new RestHandlerException(
- "Failed to serialize coordination response",
- HttpResponseStatus.INTERNAL_SERVER_ERROR,
- e));
- }
- });
+ try {
+ CompletableFuture<CoordinationResponse> responseFuture =
+ gateway.deliverCoordinationRequestToCoordinator(
+ jobId, operatorId, serializedRequest, timeout);
+ return responseFuture.thenApply(
+ coordinationResponse -> {
+ try {
+ return new ClientCoordinationResponseBody(
+ new SerializedValue<>(coordinationResponse));
+ } catch (IOException e) {
+ throw new CompletionException(
+ new RestHandlerException(
+ "Failed to serialize coordination response",
+ HttpResponseStatus.INTERNAL_SERVER_ERROR,
+ e));
+ }
+ });
+ } catch (Exception e) {
+ throw new RestHandlerException(
Review Comment:
Who is throwing an exception here? Errors shoud be returned via the returned future; they should never fail immediately.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,12 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
- log.error("Unhandled exception.", throwable);
- }
+ log.error("Unhandled exception.", throwable);
Review Comment:
I don't understand this change.
If you want an e2e test to ignore a certain exceptions in the logs, then ignore that exception in `common.sh`.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/coordination/ClientCoordinationHandlerTest.java:
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.handler.job.coordination;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.jobgraph.OperatorID;
+import org.apache.flink.runtime.rest.handler.HandlerRequest;
+import org.apache.flink.runtime.rest.handler.RestHandlerException;
+import org.apache.flink.runtime.rest.messages.job.coordination.ClientCoordinationHeaders;
+import org.apache.flink.runtime.rest.messages.job.coordination.ClientCoordinationMessageParameters;
+import org.apache.flink.runtime.rest.messages.job.coordination.ClientCoordinationRequestBody;
+import org.apache.flink.runtime.webmonitor.TestingRestfulGateway;
+import org.apache.flink.util.SerializedValue;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+/** Tests for {@link ClientCoordinationHandler}. */
+public class ClientCoordinationHandlerTest {
+ private static final JobID TEST_JOB_ID = new JobID();
+ private ClientCoordinationHandler clientCoordinationHandler;
+ private HandlerRequest<ClientCoordinationRequestBody> testRequest;
+
+ @BeforeEach
+ public void setUp() throws Exception {
+ final TestingRestfulGateway testingRestfulGateway =
+ new TestingRestfulGateway.Builder().build();
+
+ clientCoordinationHandler =
+ new ClientCoordinationHandler(
+ () -> CompletableFuture.completedFuture(testingRestfulGateway),
+ Time.seconds(10),
+ Collections.emptyMap(),
+ ClientCoordinationHeaders.getInstance());
+
+ Map<String, String> pathParameters = new HashMap<>();
+ pathParameters.put("jobid", TEST_JOB_ID.toString());
+ pathParameters.put(
+ "operatorid", OperatorID.fromJobVertexID(new JobVertexID()).toHexString());
+ testRequest =
+ HandlerRequest.resolveParametersAndCreate(
+ new ClientCoordinationRequestBody(
+ new SerializedValue<>(new TestClientCoordinationRequest())),
+ new ClientCoordinationMessageParameters(),
+ pathParameters,
+ Collections.emptyMap(),
+ Collections.emptyList());
+ }
+
+ @Test
+ public void testGetResponseException() {
+ final TestingRestfulGateway testingRestfulGateway =
+ new TestingRestfulGateway.Builder()
+ .setDeliverCoordinationRequestToCoordinatorFunction(
+ (jobId, operatorId, request) -> {
+ throw new RuntimeException("Throw runtime exception");
+ })
Review Comment:
return a failed future instead; you're testing behavior that doesnt occur at runtime.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/coordination/ClientCoordinationHandlerTest.java:
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.handler.job.coordination;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.jobgraph.OperatorID;
+import org.apache.flink.runtime.rest.handler.HandlerRequest;
+import org.apache.flink.runtime.rest.handler.RestHandlerException;
+import org.apache.flink.runtime.rest.messages.job.coordination.ClientCoordinationHeaders;
+import org.apache.flink.runtime.rest.messages.job.coordination.ClientCoordinationMessageParameters;
+import org.apache.flink.runtime.rest.messages.job.coordination.ClientCoordinationRequestBody;
+import org.apache.flink.runtime.webmonitor.TestingRestfulGateway;
+import org.apache.flink.util.SerializedValue;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+/** Tests for {@link ClientCoordinationHandler}. */
+public class ClientCoordinationHandlerTest {
+ private static final JobID TEST_JOB_ID = new JobID();
+ private ClientCoordinationHandler clientCoordinationHandler;
+ private HandlerRequest<ClientCoordinationRequestBody> testRequest;
+
+ @BeforeEach
+ public void setUp() throws Exception {
+ final TestingRestfulGateway testingRestfulGateway =
+ new TestingRestfulGateway.Builder().build();
+
+ clientCoordinationHandler =
+ new ClientCoordinationHandler(
+ () -> CompletableFuture.completedFuture(testingRestfulGateway),
+ Time.seconds(10),
+ Collections.emptyMap(),
+ ClientCoordinationHeaders.getInstance());
+
+ Map<String, String> pathParameters = new HashMap<>();
+ pathParameters.put("jobid", TEST_JOB_ID.toString());
+ pathParameters.put(
+ "operatorid", OperatorID.fromJobVertexID(new JobVertexID()).toHexString());
+ testRequest =
+ HandlerRequest.resolveParametersAndCreate(
+ new ClientCoordinationRequestBody(
+ new SerializedValue<>(new TestClientCoordinationRequest())),
+ new ClientCoordinationMessageParameters(),
+ pathParameters,
+ Collections.emptyMap(),
+ Collections.emptyList());
+ }
+
+ @Test
+ public void testGetResponseException() {
+ final TestingRestfulGateway testingRestfulGateway =
+ new TestingRestfulGateway.Builder()
+ .setDeliverCoordinationRequestToCoordinatorFunction(
+ (jobId, operatorId, request) -> {
+ throw new RuntimeException("Throw runtime exception");
+ })
+ .build();
+ assertFalse(
+ assertThrows(
+ RestHandlerException.class,
+ () ->
+ clientCoordinationHandler.handleRequest(
+ testRequest, testingRestfulGateway))
+ .logException());
Review Comment:
Use `FlinkAssertions#assertThatFuture`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22882: [FLINK-32370][runtime] Revert print error log in AbstractHandler and skip check exceptions in jdbc driver e2e tests which will check the test results itself
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1247825780
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,12 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
- log.error("Unhandled exception.", throwable);
- }
+ log.error("Unhandled exception.", throwable);
Review Comment:
This should still be reverted
##########
flink-end-to-end-tests/run-nightly-tests.sh:
##########
@@ -185,7 +185,7 @@ function run_group_2 {
run_test "Batch SQL end-to-end test using hybrid selective shuffle" "$END_TO_END_DIR/test-scripts/test_batch_sql.sh hybrid_selective"
run_test "Streaming SQL end-to-end test using planner loader" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh" "skip_check_exceptions"
run_test "Streaming SQL end-to-end test using planner with Scala version" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh scala-planner" "skip_check_exceptions"
- run_test "Sql Jdbc Driver end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh"
+ run_test "Sql Jdbc Driver end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh skip_check_exceptions"
Review Comment:
This will skip all exception checks. Are you _sure_ you want that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on a diff in pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1246282775
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,10 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
+ if (log.isDebugEnabled()) {
Review Comment:
@snuyanzin I have fixed this issue and please help to review again, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1246481365
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,12 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
- log.error("Unhandled exception.", throwable);
- }
+ log.error("Unhandled exception.", throwable);
Review Comment:
I don't understand this change.
If you want an e2e test to ignore a certain exceptions in the logs, then ignore that exception in `common.sh`.
Don't make the log messages worse to get your test to pass...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #22882: [FLINK-32370][runtime] Revert print error log in AbstractHandler and skip check exceptions in jdbc driver e2e tests which will check the test results itself
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1251044121
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,12 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
- log.error("Unhandled exception.", throwable);
- }
+ log.error("Unhandled exception.", throwable);
Review Comment:
ok :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #22882: [FLINK-32370][runtime] Revert print error log in AbstractHandler and skip check exceptions in jdbc driver e2e tests which will check the test results itself
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol merged PR #22882:
URL: https://github.com/apache/flink/pull/22882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1246421258
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##########
@@ -268,10 +266,7 @@ private CompletableFuture<Void> handleException(
HttpResponseStatus.SERVICE_UNAVAILABLE,
responseHeaders);
} else {
- if (throwable instanceof UnavailableDispatcherOperationException
- || throwable instanceof FileNotFoundException) {
- log.debug("Job is not initialized or is finished: {}", throwable.getMessage());
- } else {
+ if (log.isDebugEnabled()) {
Review Comment:
Thanks for addressing comment
I guess I'm not the best person to review here since I 'm not aware of this Flink area enough...
May be another pair of eyes would be good
// cc @libenchao since I noticed you've reviewed previous jdbc related PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22882:
URL: https://github.com/apache/flink/pull/22882#issuecomment-1609700229
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5b03cd745eec13082d852c04e2becfae5c070115",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5b03cd745eec13082d852c04e2becfae5c070115",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5b03cd745eec13082d852c04e2becfae5c070115 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on a diff in pull request #22882: [FLINK-32370][runtime] Revert print error log in AbstractHandler and skip check exceptions in jdbc driver e2e tests which will check the test results itself
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1248421262
##########
flink-end-to-end-tests/run-nightly-tests.sh:
##########
@@ -185,7 +185,7 @@ function run_group_2 {
run_test "Batch SQL end-to-end test using hybrid selective shuffle" "$END_TO_END_DIR/test-scripts/test_batch_sql.sh hybrid_selective"
run_test "Streaming SQL end-to-end test using planner loader" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh" "skip_check_exceptions"
run_test "Streaming SQL end-to-end test using planner with Scala version" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh scala-planner" "skip_check_exceptions"
- run_test "Sql Jdbc Driver end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh"
+ run_test "Sql Jdbc Driver end-to-end test" "$END_TO_END_DIR/test-scripts/test_sql_jdbc_driver.sh skip_check_exceptions"
Review Comment:
@zentol Yes, the test_sql_jdbc_driver will checkout its query results in another files, all exceptions and error logs during this process are mainly for future issue analysis and are acceptable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org