You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/29 04:28:00 UTC

[jira] [Commented] (WEEX-154) Weex render and other thin but critical issues should be classify to render container by call render of exception callback

    [ https://issues.apache.org/jira/browse/WEEX-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270117#comment-16270117 ] 

ASF GitHub Bot commented on WEEX-154:
-------------------------------------

GitHub user atomtong opened a pull request:

    https://github.com/apache/incubator-weex/pull/920

    [WEEX-154][Android] Weex render and other thin but critical issues should be classify to render container by call render of exception callback

    
    * see
       https://issues.apache.org/jira/browse/WEEX-154
    
    Rendering or other thin but critical issues in Weex SDK should be classified to render container by call render of exception callback.
    In order to classify Weex SDK those problems, we are clearing up error code and degrade code for render container。
    in detail, error code classified by js framework initializing, js bundle download, js bundle rendering and another process.
    WXErrorCode and WXRenderErrorCode is the specific class to define those errors.and we can call WXExceptionUtils's commit method to track those errors immediately to some RT userlog analyzing platform.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atomtong/incubator-weex android-feature-dev-tools-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/920.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #920
    
----
commit 2643affed852851245dc433bba2451238e928c66
Author: atomtong <to...@qq.com>
Date:   2017-10-17T04:03:16Z

    * [android] add WXExceptionsUtil to support commitCriticalExceptionRT eg . crash platform

commit d69a7188cdb146ac00b4904f0ba87dd443371ed5
Author: atomtong <to...@qq.com>
Date:   2017-10-18T07:38:42Z

    * [android] fix action is null NPE

commit a8df57bf8422a4765cb03332d12335e01d8a7e3d
Author: atomtong <to...@qq.com>
Date:   2017-10-18T07:41:54Z

    Merge branch 'release-0.16' into android-feature-dev-tools-exception
    
    * release-0.16: (60 commits)
      * [android] fix code style
      * [android] fix on android 4.0.* platform cannot startup multiprocess    since on android 4.1 use ANDROID_PIE to ensure safety    on android api 15 or below use libweexjst.so to startup new process
      * [test] update border base png
      Revert "* [test] vilid protect for danger ci"
      * [test] valid protect for danger file
      * [test] vilid protect for danger ci
      * [test] add log for danger test
      resolve  conflicts
      sticky offset supported, keep position lost when insert data fix
      resolve  conflicts
      * [ios] web filter error
      * [android] fix unit android test log mocked
      * [test] add log for danger test
      resolve  conflicts
      sticky offset supported, keep position lost when insert data fix
      resolve  conflicts
      * [ios] web filter error
      * [android] add test case
      * [android] fix unit android test log mocked
      * [android] modify log print
      ...

commit 1163c92c8298c3bcadc3420dd83492dbfedfe560
Author: atomtong <to...@qq.com>
Date:   2017-10-19T02:53:37Z

    Merge branch 'release-0.16-github' into android-feature-dev-tools-exception
    
    * release-0.16-github:
      * [android] fix crash when set box-shadow on horizontal scroller
      * [test] update travisCI , remove iOS env.
      * [Android] Fix that moveElement doesn't work when parent is not a list
      * [android] if not debug level then write console log
      * [android] delete redundancy log print logic code
      * [android] fix bug if application is null log not print out
      fix clipPath not works on android N 7.0
      * [android] fix redundant input event
      * [android] null judgement
      * [android] fix shadow remains after component size changed
      * [android] fix flicker caused by coexistence of box-shadow and border-radius

commit f57ae34cb07a898fab75f6c9a2fcc371e2d1240c
Author: atomtong <to...@qq.com>
Date:   2017-10-19T06:08:12Z

    Merge branch 'release-0.16' into android-feature-dev-tools-exception
    
    * release-0.16:
      * [android] fix wrong logic when set box-shadow on adapter view
      * [ios] add jserror upload method, add trigger positions on sdk init,jsservice,jsbridge
      * [android] fix imagesave permissions
      + [jsfm] add weex variable api in runtime

commit 46f9950791c3828f80a54ee1f84ad0c23d65671e
Author: atomtong <to...@qq.com>
Date:   2017-10-19T08:01:39Z

    * [android] commit exception js excute and init exceptions

commit 4a6207e8f741925c45df56d56e654c9f4d75f476
Author: atomtong <to...@qq.com>
Date:   2017-10-19T08:12:00Z

    * [test] add WXExceptionUtils unit test

commit 55b0b7aba52c8677de101872e46439c0db07c4d4
Author: atomtong <to...@qq.com>
Date:   2017-10-25T13:27:37Z

    * [android] add commit detail log

commit 6421dfb070e35871889bac5567fa5d8cb2297a53
Author: atomtong <to...@qq.com>
Date:   2017-10-25T13:27:49Z

    Merge branch 'release-0.16-github' into android-feature-dev-tools-exception
    
    * release-0.16-github: (22 commits)
      * [android] add switcher to disable box-shadow globally
      apply style spans to  ellipsis, and keep new static layout params same with create layout when truncate
      * [android] add border-android.png
      Revert: Revert: Revert: * [android] modify border-android.png
      Revert: Revert: * [android] modify border-android.png
      Revert: * [android] modify border-android.png
      remove chinese comment
      * [android] modify border-android.png
      * [android] memory optimized for box-shadow
      * [test] add console log when error
      * [test] update danger, to protect unknown error
      add response header and use hashmap to handle null key,value
      * [jsfm] jsfm update to 0.22.7 fix dom action updatefinish  before createbody action
      * [android] add box shadow host on div
      * [android] draw box-shadow on ViewGroup directly
      * [android] fix wrong logic when set box-shadow on adapter view
      + [jsfm] add weex variable api in runtime
      template md5 and bytes length, response header  on js exception scene
      * [jsfm] jsfm update to 0.22.7 fix dom action updatefinish  before createbody action
      when touch  use scroll handler, when none touch use nonstop
      ...

commit e86a67750ea604f74d436062b03c42704acfb47e
Author: atomtong <to...@qq.com>
Date:   2017-10-30T07:47:35Z

    Merge branch 'release-0.16-github' into android-feature-dev-tools-exception
    
    * release-0.16-github:
      close auto  bitmap recycle
      image recycle enable  auto release image reduce memory usage
      * [android] memory optimization for box-shadow
      * [android] exception opt, on debug apk connecting debug server will hold on and wait initframework, on release will return and use H5 render soon
      * [android] create instance exception when jsf not ready or jsc cannot start up will use h5 to render page

commit d2984be94094dd2145e9477b28883d976a16717d
Author: atomtong <to...@qq.com>
Date:   2017-11-14T10:03:01Z

    Merge branch 'release-0.16-android-bugfixed-logtrack' into android-feature-dev-tools-exception
    
    * release-0.16-android-bugfixed-logtrack:
      * [android] add invokeExecJS log to logwatcher
      remove unused log edit
      remove unused log edit
      [android] remove debug log  into debug mode
      * [android] abstract transform parse code, share code
      * [android] weex transition support on android platform, improve batch time when layout
      * [android] android  bugfixed logwatcher
      * [devtool] fix devtool network mode
      * [android] log track adapter fix logLevel
      * [android] release log analyse logwatcher
      * [android] android  bugfixed logwatcher
      when header view has parent, remove it from parent
      remove log when app run, improve performance
      * [android] change format data
      * [android] register dim and mes
      * [android] get screenreader time add mtop coume time
      onVisibilityChanged most sense right. but when native component custom set parent visibility, the method not paired on some platform, e.g when parent become invisible, changedView is this, visibility is invisible.
      * [html5] bugfix:   - scroll event listenning on window.   - img lazyloading.   - scrollToElement on latest chrome.   - rm id of a comp.   - fix stream.fetch.   - add statistics for components and modules.   - support lazyload and appear watcher when body height set to 100%   - add try catch for accessing localStorage may throw a error.   - image support sprite (sprite-src, sprite-position, sprite-width).   - fix indicator when there's only one slide in slider.
      * [devtool] fix devtool network mode
      when cell amount is big, watch appear will none changed will result too many logs when scroll, move log to appear changed

commit 1271b8eb5c47c416f3584d8ee2b1c8bcf03f24cf
Author: atomtong <to...@qq.com>
Date:   2017-11-16T07:41:43Z

    Merge branch 'master' into android-feature-dev-tools-exception
    
    * master: (39 commits)
      * [test] update image compare border
      * [test] update image compare png
      * [android] removing the legacy module weex_debug
      * [test] update danger file, remove find reviewer for API rate limit exceeded
      * [android] add NPE protection
      [WEEX-109][android] support scroll start scroll end event on scroller list  template list, handle pull action when nestedScrollingEnable false
      * [android] comment position fixed
      [WEEX-110][android]WXSwipeLayout support nested scroll for list
      [ios] delete some spaces.
      [WEEX-109][android] support scroll start scroll end event on scroller list  template list
      * [ios] add instanceId to performance dict, that we can differentiate instance exactly。
      - [test] close invalid pull requests
      - [test] close #832
      * [test] fix the unit test script of weex-js-runtime
      * [ios] fix #WEEX-88, support BOOL type argument bridging when in 32-bit iOS and add related unit test.
      + [jsfm] add a simple tracker for legacy .we framework
      + [jsfm] support register and trigger component hooks
      [WEEX-99][iOS] fix setViewport: sometimes doesn't work
      [WEEX-96][iOS] bug-fix about timer exposed on JSContext
      [WEEX-94][iOS] fix iOS 8 scrollview assign delegate crash
      ...

commit 7a914885a83cc5c7d227ab9faef9e4c9152a217f
Author: atomtong <to...@qq.com>
Date:   2017-11-16T08:32:44Z

    * [android] sdk init process critical issues committed RT

commit c9a9317173d5bf03f39036b490cdf305d22884cc
Author: misakuo <mi...@apache.org>
Date:   2017-11-16T09:25:32Z

    * [android] avoid crash on some device caused by RippleDrawable
    
    (cherry picked from commit 1f7a309)

commit 797f3150d1b3e64f63b8b0726c57d4d0ad4897b4
Author: atomtong <to...@qq.com>
Date:   2017-11-16T10:00:22Z

    * [android] add invoke register module,componet or jsservice exception commit RT

commit 32db62b4377f224a0ac3bec272d265185af641f8
Author: atomtong <to...@qq.com>
Date:   2017-11-16T11:06:17Z

    Merge branch 'master' into release-0.16-gitlab
    
    * master:
      revert clip path targetview judge.
      * [android] avoid crash on some device caused by RippleDrawable
      [WEEX-107] [android] layer type none has some bug on some platform. force layer type soft for render text right
      * [test] update image compare border
      * [test] update image compare png

commit e5ebfbdb33d28b631756ad8dd7e74f516bfdf62e
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date:   2017-11-17T03:03:30Z

    Merge branch 'master' of https://github.com/apache/incubator-weex into release-0.16-gitlab

commit 164a90192cc1282cc8b54133918616c85b7e1088
Author: atomtong <to...@qq.com>
Date:   2017-11-20T06:52:41Z

    * [android] network and inspector bug fixed

commit da3f988a4a3fce76f8ce25269941a7d7c250d407
Author: atomtong <to...@qq.com>
Date:   2017-11-20T06:53:11Z

    Merge branch 'master' into android-feature-dev-tools-exception
    
    * master: (28 commits)
      [WEEX-134][android] createInstance and initFramework may on different Thread, add volatile static for mInit
      * [ios] update compare png for border
      [WEEX-127][android]Use HashSet Instead of array, because some app not contains arrayset
      * [ios] update compare png for compositing
      Revert "* [ios] fix bugs about transform's parse problem"
      Revert "* [ios] fix parse transform with translate(20px,20px)"
      Revert "[WEEX-124][iOS] bugfix transform crash about unknow selector"
      [WEEX-124][iOS] bugfix transform crash about unknow selector
      * [ios] update pod version
      [WEEX-126][iOS] protect for pagename when need send jserror 1. compatible old logic; 2. use instance.pageName as default for front user.
      * [ios] fix parse transform with translate(20px,20px)
      * [ios] fix bugs and add examples for scrollstart and scrollend
      revert clip path targetview judge.
      * [ios] improve transition's stability
      * [android] avoid crash on some device caused by RippleDrawable
      * [ios] fix bugs about transform's parse problem
      [WEEX-107] [android] layer type none has some bug on some platform. force layer type soft for render text right
      [WEEX-102][iOS] bug-fix default config center return value
      [WEEX-102][iOS]bugfix appear event will fire wrongly while the view has not been loaded
      [WEEX-121][iOS] bug-fix draw text crash
      ...

commit e9871804d23e1193efc9f778097ee429ad5d51da
Author: atomtong <to...@qq.com>
Date:   2017-11-20T07:48:12Z

    * [android] register modules bug

commit b3d61fea98912a2eac01f99f1355548525b76dc1
Author: atomtong <to...@qq.com>
Date:   2017-11-20T07:49:21Z

    * [android] remove debug inspecter init

commit 1239baf5a42a039d471a3973248fd7ece4d2a579
Author: atomtong <to...@qq.com>
Date:   2017-11-20T07:52:53Z

    Merge branch 'master' into release-0.16-gitlab
    
    * master:
      * [android] fix page oin slider can not receive the lifecycle callbacks
      [WEEX-134][android] createInstance and initFramework may on different Thread, add volatile static for mInit
      * [ios] update compare png for border

commit e2a98e66b03add6dfd773980ce16c12fdb477de1
Author: atomtong <to...@qq.com>
Date:   2017-11-21T05:21:56Z

    Merge branch 'master' into android-feature-dev-tools-exception
    
    * master:
      close #790,close #796,close #801,close #803
      close #884,close #886,close #889
      -[test] close #887
      resolve #887
      [WEEX-132][iOS] support text writing direction from right to left
      [WEEX-133][iOS] support word-wrap on iOS when drawing text
      [WEEX-129][android] Appear Event Be Fired Multi Times And Event not watch be fired
      [WEEX-124][android]fix android bug
      * [android] fix page oin slider can not receive the lifecycle callbacks

commit bbd4f179dc0a286c08375be81e519f54cdeda412
Author: atomtong <to...@qq.com>
Date:   2017-11-21T08:20:48Z

    * [anroid] prepare grey test issues add over

commit 51e8aada76bcc12072cce53cfa5e65ca24c3b19c
Author: atomtong <to...@qq.com>
Date:   2017-11-21T10:08:49Z

    * [android] creatFinish Action now posed track

commit ce8c0edea847e4d1717f3a384832b911cec1131a
Author: atomtong <to...@qq.com>
Date:   2017-11-21T11:16:29Z

    * [android] add first dom action seq track

commit 9bc87537e29220ccad05a1425775bf295e40c99d
Author: atomtong <to...@qq.com>
Date:   2017-11-22T12:21:17Z

    * [android]add degrade code and case

commit c7e948b544c3c38309ba793979e9da3149edcfe8
Author: atomtong <to...@qq.com>
Date:   2017-11-22T12:21:58Z

    Merge branch 'master' into release-0.16-gitlab
    
    * master:
      * [doc] publish 0.17.0 release note
      [WEEX-112][iOS] make weex playground app adapt to iPhone X
      close #896
      * [test] bug fix , compatibility of maraca can't find element
      [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it.
      close #822
      Add mavenLocal before jcenter repository
      Remove maven central repository, use only jcenter
      close #790,close #796,close #801,close #803
      close #884,close #886,close #889
      -[test] close #887
      resolve #887
      [WEEX-132][iOS] support text writing direction from right to left
      [WEEX-133][iOS] support word-wrap on iOS when drawing text
      [WEEX-129][android] Appear Event Be Fired Multi Times And Event not watch be fired
      [WEEX-124][android]fix android bug

commit 392188b890976b0a67bd6a2b22bce310874fbffb
Author: atomtong <to...@qq.com>
Date:   2017-11-22T12:22:25Z

    Merge branch 'release-0.16-gitlab' into android-feature-dev-tools-exception
    
    * release-0.16-gitlab:
      * [doc] publish 0.17.0 release note
      [WEEX-112][iOS] make weex playground app adapt to iPhone X
      close #896
      * [test] bug fix , compatibility of maraca can't find element
      [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it.
      close #822
      Add mavenLocal before jcenter repository
      Remove maven central repository, use only jcenter
      * [android] avoid crash on some device caused by RippleDrawable

commit eeee0b466334079d9f3526d9564fb612f26358ee
Author: atomtong <to...@qq.com>
Date:   2017-11-22T13:38:39Z

    * [android] remove log and revert jsfm version to 0.22.7

----


> Weex render and other thin but critical issues should be classify to render container by call render of exception callback
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WEEX-154
>                 URL: https://issues.apache.org/jira/browse/WEEX-154
>             Project: Weex
>          Issue Type: New Feature
>          Components: Android, iOS, JSFM
>            Reporter: atomtong
>            Assignee: zhengshihan
>            Priority: Minor
>              Labels: features
>
> hi guys,
> Rendering or other thin but critical issues in Weex SDK should be classified to render container by call render of exception callback.
> In order to classify Weex SDK those problems,  we are clearing up error code and degrade code for render container。
> in detail, error code classified by js framework initializing, js bundle download, js bundle rendering and another process.
> WXErrorCode and WXRenderErrorCode is the specific class to define those errors.and we can call WXExceptionUtils's commit method to track those errors immediately to some RT userlog analyzing platform. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)