You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "limeschnaps (via GitHub)" <gi...@apache.org> on 2026/07/16 13:00:30 UTC
[PR] Fix `Trigger.submit_event` to route asset events through the configured `asset_manager` [airflow]
limeschnaps opened a new pull request, #69966:
URL: https://github.com/apache/airflow/pull/69966
closes: #69962
## What
`Trigger.submit_event` imported the base `AssetManager` class and called
`AssetManager.register_asset_change(...)` on it, instead of using the resolved
`asset_manager` singleton like every other call site
(`taskinstance.py`, the public assets REST route). Because
`register_asset_change` is a classmethod invoked on the base class, a custom
manager configured via `[core] asset_manager_class` was silently bypassed for
asset events produced by triggers / asset watchers.
This swaps the import and call to the configured `asset_manager` instance, so
`asset_manager_class` now applies uniformly regardless of how an asset event is
produced.
## Why
`asset_manager_class` is the only supported extension point for asset-event
handling, and it did not apply to trigger/watcher-produced events — the one
place a custom manager could not be reached.
## Tests
- Added `test_submit_event_uses_configured_asset_manager`: asserts
`submit_event` dispatches through the module-level `asset_manager` instance.
Fails on `main`, passes with the fix.
- Updated `test_submit_event_no_n_plus_one_for_assets` to patch
`airflow.assets.manager.AssetManager.register_asset_change` (where the
classmethod is defined) so it no longer depends on the removed module symbol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `Trigger.submit_event` to route asset events through the configured `asset_manager` [airflow]
Posted by "limeschnaps (via GitHub) via commits" <co...@airflow.apache.org>.
limeschnaps commented on PR #69966:
URL: https://github.com/apache/airflow/pull/69966#issuecomment-6544907836
Will this pull request be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `Trigger.submit_event` to route asset events through the configured `asset_manager` [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69966:
URL: https://github.com/apache/airflow/pull/69966#issuecomment-6457231895
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `Trigger.submit_event` to route asset events through the configured `asset_manager` [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #69966:
URL: https://github.com/apache/airflow/pull/69966#issuecomment-4992153416
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org