You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:10:52 UTC
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4454: user/trap: Set MQ_MAXMSGSIZE to 64 to get NX working
gustavonihei commented on a change in pull request #4454:
URL: https://github.com/apache/incubator-nuttx/pull/4454#discussion_r699654915
##########
File path: sched/Kconfig
##########
@@ -1588,7 +1588,8 @@ config PREALLOC_MQ_IRQ_MSGS
config MQ_MAXMSGSIZE
int "Maximum message size"
- default 32
+ default 32 if !NX
Review comment:
I agree with the motivation, but the proposed solution fails to achieve its intent.
The default value of 64 will only be effective in the following scenario:
1) User selects `CONFIG_DISABLE_MQUEUE` for deactivating message queue support
2) User enables `CONFIG_NX`
3) User deselects `CONFIG_DISABLE_MQUEUE`
So, given the need for this very specific scenario, I believe we need a better solution.
##########
File path: sched/Kconfig
##########
@@ -1588,7 +1588,8 @@ config PREALLOC_MQ_IRQ_MSGS
config MQ_MAXMSGSIZE
int "Maximum message size"
- default 32
+ default 32 if !NX
Review comment:
I agree with the motivation, but the proposed solution fails to achieve its intent.
The default value of 64 will only be effective in the following scenario:
1) User selects `CONFIG_DISABLE_MQUEUE` for deactivating message queue support
2) User enables `CONFIG_NX`
3) User deselects `CONFIG_DISABLE_MQUEUE`
So, given the need for this very specific scenario, I believe we need a better solution.
##########
File path: sched/Kconfig
##########
@@ -1588,7 +1588,8 @@ config PREALLOC_MQ_IRQ_MSGS
config MQ_MAXMSGSIZE
int "Maximum message size"
- default 32
+ default 32 if !NX
Review comment:
I agree with the motivation, but the proposed solution fails to achieve its intent.
The default value of 64 will only be effective in the following scenario:
1) User selects `CONFIG_DISABLE_MQUEUE` for deactivating message queue support
2) User enables `CONFIG_NX`
3) User deselects `CONFIG_DISABLE_MQUEUE`
So, given the need for this very specific scenario, I believe we need to come up with a better solution.
##########
File path: sched/Kconfig
##########
@@ -1588,7 +1588,8 @@ config PREALLOC_MQ_IRQ_MSGS
config MQ_MAXMSGSIZE
int "Maximum message size"
- default 32
+ default 32 if !NX
Review comment:
Imposing a default value for a given config is not scalable. Imagine if 300 configs required a different default value, it would become messy.
It would be better if each config/subsystem performs a sanity check, either in Kconfig via `depends on` or at build time.
##########
File path: sched/Kconfig
##########
@@ -1588,7 +1588,8 @@ config PREALLOC_MQ_IRQ_MSGS
config MQ_MAXMSGSIZE
int "Maximum message size"
- default 32
+ default 32 if !NX
Review comment:
Imposing a default value for a given config is not scalable. Imagine if 300 configs required a different default value, it would become messy.
It would be better if each config/subsystem performs a sanity check, either in Kconfig via `depends on` or at build time (preferrable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org