[GitHub] [spark] cloud-fan commented on a change in pull request #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #26750: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider
URL: https://github.com/apache/spark/pull/26750#discussion_r354692859
 
 

 ##########
 File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableProvider.java
 ##########
 @@ -36,26 +38,47 @@
 public interface TableProvider {
 
   /**
-   * Return a {@link Table} instance to do read/write with user-specified options.
+   * Return a {@link Table} instance with specified table properties to do read/write.
+   * Implementations should infer the table schema and partitioning.
+   *
+   * @param properties The specified table properties. It's case preserving (contains exactly what
 
 Review comment:
   a path based table would have a `location` table property, but I don't know why we can't reuse the old name `path`. cc @rdblue 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org