You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2018/04/26 18:31:01 UTC
[GitHub] storm pull request #2646: [YSTORM-4915] AutoTGT should check if a TGT is add...
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2646
[YSTORM-4915] AutoTGT should check if a TGT is address-less and reject if it's not
https://issues.apache.org/jira/browse/STORM-3044
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ethanlm/storm STORM-3044
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2646
----
commit a3e96641731a784e45075650d5dd999e2b36601b
Author: Ethan Li <et...@...>
Date: 2018-04-26T18:30:24Z
[YSTORM-4915] AutoTGT should check if a TGT is address-less and reject if it's not
----
---
[GitHub] storm issue #2646: [STORM-3044] AutoTGT should check if a TGT is address-les...
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2646
@HeartSaVioR Thanks very much!
---
[GitHub] storm pull request #2646: [STORM-3044] AutoTGT should check if a TGT is addr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2646
---
[GitHub] storm issue #2646: [YSTORM-4915] AutoTGT should check if a TGT is address-le...
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2646
The failures should be unrelated. The build succeeded on my repo https://travis-ci.org/Ethanlm/storm/builds/371698263
---
[GitHub] storm issue #2646: [STORM-3044] AutoTGT should check if a TGT is address-les...
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2646
@HeartSaVioR Sorry I forgot to change it. I don't see any merge button. Do I need to do it in some other way
---
[GitHub] storm issue #2646: [STORM-3044] AutoTGT should check if a TGT is address-les...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2646
@Ethanlm
You can refer the DEVELOPER doc which guides contributors as well as committers.
https://github.com/apache/storm/blob/master/DEVELOPER.md#merge-a-pull-request-or-patch
You would want to read BYLAWS for Storm project as well: http://storm.apache.org/contribute/BYLAWS.html
Please keep in mind we need to wait for 24hrs to merge code change. :) So you would like to try it out after 5 hours later.
---