You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/01/05 09:04:35 UTC
[GitHub] [incubator-echarts] pissang opened a new pull request #13948: chore: rollup from lib in bundling. add ts check script
pissang opened a new pull request #13948:
URL: https://github.com/apache/incubator-echarts/pull/13948
This pull request did some changes to the build pipeline.
1. Rollup from the generated lib folder instead of the source folder. Which can avoid unnecessary typescript transpile and speedup the bundling process.
2. Simplify the build script, remove some unnecessary arguments.
3. Add typescript check command: `npm run checktype`. Which will also be run before commit and in CI.
4. Update the guideline in README
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang closed pull request #13948: chore: rollup from lib in bundling. add ts check script
Posted by GitBox <gi...@apache.org>.
pissang closed pull request #13948:
URL: https://github.com/apache/incubator-echarts/pull/13948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13948: chore: rollup from lib in bundling. add ts check script
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13948:
URL: https://github.com/apache/incubator-echarts/pull/13948#issuecomment-754505265
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org