[GitHub] [druid] jihoonson edited a comment on issue #11256: Reduce method invocation of reservoir sampling

[GitBox <gi...@apache.org>]

jihoonson edited a comment on issue #11256:
URL: https://github.com/apache/druid/issues/11256#issuecomment-841118335


   @yuanlihan thanks. I think I was confused about what is expensive. I think what is expensive is not the sample method invocation, but is the algorithm that calls the sample method over again. I looked over your PR and seems reasonable to me. But I want to think about it more because we have no test coverage on the long term effect of this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org