You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/10 00:05:30 UTC
[GitHub] [spark] gemelen opened a new pull request #32115: Migrate to `slash` syntax
gemelen opened a new pull request #32115:
URL: https://github.com/apache/spark/pull/32115
### What changes were proposed in this pull request?
SBT 1.5.0 deprecates `in` syntax from 0.13.x, so build file adjustment
is recommended.
See https://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html#Migrating+to+slash+syntax
### Why are the changes needed?
Removes significant amount of deprecation warnings and prepares to syntax removal in next versions of SBT.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Build should pass on GH Actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817036372
Hi, @gemelen . GitHub Action seems to complain. Could you fix it?
```
[error] /home/runner/work/spark/spark/project/SparkBuild.scala:647:85: type mismatch;
[error] found : sbt.TaskKey[java.io.File]
[error] required: sbt.Task[java.io.File] => ?
[error] dockerBuild := dockerBuild.dependsOn((assembly / packageBin in Compile)(Compile / packageBin))
[error] ^
[error] /home/runner/work/spark/spark/project/SparkBuild.scala:648:61: type mismatch;
[error] found : sbt.TaskKey[java.io.File]
[error] required: sbt.Task[java.io.File] => ?
[error] .dependsOn((examples / packageBin in Compile)(Compile / packageBin)).value
[error] ^
[error] /home/runner/work/spark/spark/project/SparkBuild.scala:441:127: type mismatch;
[error] found : sbt.TaskKey[java.io.File]
[error] required: sbt.Task[java.io.File] => ?
[error] val args = Seq("--packages", packages, "--class", className, (LocalProject("core") / Keys.`package` in Compile)(Compile / Keys.`package`)
[error] ^
[error] three errors found
[error] (Compile / compileIncremental) Compilation failed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32115: [SPARK-35023][BUILD] Migrate from deprecated `in` to `slash` syntax in SBT build file
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32115:
URL: https://github.com/apache/spark/pull/32115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817048654
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41736/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817038939
**[Test build #137155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137155/testReport)** for PR 32115 at commit [`96c56fa`](https://github.com/apache/spark/commit/96c56fa84917ba60ab1723ec4d9d8905f060ff7c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gemelen commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
gemelen commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817037238
@dongjoon-hyun yes, sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817048131
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41734/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817039194
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137155/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gemelen commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
gemelen commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817104519
I wasn't able to reproduce latest test errors. Could please somebody re-launch the tests here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817069765
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817048665
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41736/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817038939
**[Test build #137155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137155/testReport)** for PR 32115 at commit [`96c56fa`](https://github.com/apache/spark/commit/96c56fa84917ba60ab1723ec4d9d8905f060ff7c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gemelen commented on pull request #32115: [SPARK-35023][BUILD] Migrate from deprecated `in' to `slash` syntax in SBT build file
Posted by GitBox <gi...@apache.org>.
gemelen commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817285788
@HyukjinKwon @dongjoon-hyun
ticket for tracking created.
please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817040851
**[Test build #137157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137157/testReport)** for PR 32115 at commit [`34903b2`](https://github.com/apache/spark/commit/34903b2f0ec706e3ee5fbbe56aba172f553dd2bd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817039194
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137155/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817040851
**[Test build #137157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137157/testReport)** for PR 32115 at commit [`34903b2`](https://github.com/apache/spark/commit/34903b2f0ec706e3ee5fbbe56aba172f553dd2bd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32115: [SPARK-35023][BUILD] Migrate from deprecated `in` to `slash` syntax in SBT build file
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817443251
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817048665
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41736/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817236999
Thanks @gemelen for tracking and fixing SBT. BTW, I think it should be best to file a JIRA and link it to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817067724
**[Test build #137157 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137157/testReport)** for PR 32115 at commit [`34903b2`](https://github.com/apache/spark/commit/34903b2f0ec706e3ee5fbbe56aba172f553dd2bd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817036372
Hi, @gemelen . GitHub Action seems to complain. Could you fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817048131
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41734/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817069765
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817046907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32115: Migrate to `slash` syntax
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32115:
URL: https://github.com/apache/spark/pull/32115#issuecomment-817039187
**[Test build #137155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137155/testReport)** for PR 32115 at commit [`96c56fa`](https://github.com/apache/spark/commit/96c56fa84917ba60ab1723ec4d9d8905f060ff7c).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org