You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/18 05:34:06 UTC
[GitHub] [apisix-dashboard] qq54903099 opened a new issue #2286: /debug/pprof/ this api un auth
qq54903099 opened a new issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286
### Issue description
/debug/pprof/ 未登录的情况下可以直接访问
### Expected behavior
/debug/pprof/ 未登录不能访问
### How to Reproduce
curl localhost:9000/debug/pprof/
### Screenshots
_No response_
### Environment
- apisix version (cmd: `apisix version`):
- OS (cmd: `uname -a`):
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `etcd --version`):
- apisix-dashboard version, if have: 2.10
- Browser version, if have:
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist edited a comment on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
zaunist edited a comment on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1016474491
>
I'm not sure how do you want to do, can you give some example ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1021239735
Maybe we can add a configuration item that is turned off by default, I don't think the pforf API is very meaningful for dashboard. I.e., turn off this API by default and turn it on by modifying the configuration when you need to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1017185875
>
@jwrookie . You can submit a PR to accomplish your idea, and other community member will review your code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] jwrookie commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
jwrookie commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1017399491
droplet nonsupport set cookie :disappointed_relieved:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] jwrookie commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
jwrookie commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1049417632
If it is not connected to `prometheus` or other similar tools, I recommend using it for continuous monitoring and analysis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1016474491
>
I'm not sure what do you want to do, can you give some example ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1015145201
@qq54903099 Thansk for your comment, we will check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1017054892
>
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] jwrookie commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
jwrookie commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1016444383
can i base on cookie to fast fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1021239735
Maybe we can add a configuration item that is turned off by default, I don't think the pforf API is very meaningful for dashboard. I.e., turn off this API by default and turn it on by modifying the configuration when you need to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] jwrookie commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
jwrookie commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1017045980
currently, `user authentication` is done through http headers, can not auto add the headers on a newtab for `/debug/pprof`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist edited a comment on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
zaunist edited a comment on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1016205329
@jwrookie You are right! Welcome to pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] jwrookie edited a comment on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
jwrookie edited a comment on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1016086849
ref : https://github.com/apache/apisix-dashboard/blob/131601d51d06fd093e9af9e43384b7009a34d7dd/api/internal/filter/authentication.go#L30-L37
path : /debug/pprof omited the auth check, by design?
I'd be happy to fix it if you want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1016205329
>
You are right! Welcome to pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1049405190
And I'm glad to contribute this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
zaunist commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1049404893
Hi, community. IMO, since this interface is very rarely used, I suggest removing pprof and adding one manually for debugging if needed in development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] jwrookie commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
jwrookie commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1023801274
>
but at turn it on, the problem will reproduce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] jwrookie commented on issue #2286: /debug/pprof/ this api un auth
Posted by GitBox <gi...@apache.org>.
jwrookie commented on issue #2286:
URL: https://github.com/apache/apisix-dashboard/issues/2286#issuecomment-1016086849
ref : https://github.com/apache/apisix-dashboard/blob/master/api/internal/filter/authentication.go#L34
path : /debug/pprof omited the auth check, by design?
I'd be happy to fix it if you want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org