You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/10/23 07:13:45 UTC

[GitHub] [carbondata] QiangCai commented on a change in pull request #3982: [CARBONDATA-4032] Fix drop partition command clean data issue

QiangCai commented on a change in pull request #3982:
URL: https://github.com/apache/carbondata/pull/3982#discussion_r510680548



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/partition/CarbonAlterTableDropHivePartitionCommand.scala
##########
@@ -181,9 +182,11 @@ case class CarbonAlterTableDropHivePartitionCommand(
       OperationListenerBus.getInstance().fireEvent(postStatusEvent, operationContext)
 
       IndexStoreManager.getInstance().clearIndex(table.getAbsoluteTableIdentifier)
+      tobeCleanSegs.addAll(tobeUpdatedSegs)
+      tobeCleanSegs.addAll(tobeDeletedSegs)

Review comment:
       add all twice?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org