You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by uc...@apache.org on 2016/11/02 10:22:06 UTC
flink git commit: [FLINK-4398] [query] Improve logging and error
message in failing KvStateServerHandlerTest
Repository: flink
Updated Branches:
refs/heads/master d1fea2646 -> 2b369d37f
[FLINK-4398] [query] Improve logging and error message in failing KvStateServerHandlerTest
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/2b369d37
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/2b369d37
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/2b369d37
Branch: refs/heads/master
Commit: 2b369d37fcb3dace603ff2d79382008a8b5bb806
Parents: d1fea26
Author: Ufuk Celebi <uc...@apache.org>
Authored: Wed Nov 2 11:21:39 2016 +0100
Committer: Ufuk Celebi <uc...@apache.org>
Committed: Wed Nov 2 11:21:39 2016 +0100
----------------------------------------------------------------------
.../runtime/query/netty/AtomicKvStateRequestStats.java | 10 ++++++++++
.../runtime/query/netty/KvStateServerHandlerTest.java | 9 ++++-----
2 files changed, 14 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/2b369d37/flink-runtime/src/main/java/org/apache/flink/runtime/query/netty/AtomicKvStateRequestStats.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/query/netty/AtomicKvStateRequestStats.java b/flink-runtime/src/main/java/org/apache/flink/runtime/query/netty/AtomicKvStateRequestStats.java
index 2fca4a8..1d80bab 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/query/netty/AtomicKvStateRequestStats.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/query/netty/AtomicKvStateRequestStats.java
@@ -91,4 +91,14 @@ public class AtomicKvStateRequestStats implements KvStateRequestStats {
public long getNumFailed() {
return numFailed.get();
}
+
+ @Override
+ public String toString() {
+ return "AtomicKvStateRequestStats{" +
+ "numConnections=" + numConnections +
+ ", numRequests=" + numRequests +
+ ", numSuccessful=" + numSuccessful +
+ ", numFailed=" + numFailed +
+ '}';
+ }
}
http://git-wip-us.apache.org/repos/asf/flink/blob/2b369d37/flink-runtime/src/test/java/org/apache/flink/runtime/query/netty/KvStateServerHandlerTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/query/netty/KvStateServerHandlerTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/query/netty/KvStateServerHandlerTest.java
index ed4a822..463d166 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/query/netty/KvStateServerHandlerTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/query/netty/KvStateServerHandlerTest.java
@@ -46,6 +46,7 @@ import org.apache.flink.runtime.state.KvState;
import org.apache.flink.runtime.state.VoidNamespace;
import org.apache.flink.runtime.state.VoidNamespaceSerializer;
import org.apache.flink.runtime.state.memory.MemoryStateBackend;
+import org.apache.flink.util.TestLogger;
import org.junit.AfterClass;
import org.junit.Test;
@@ -60,7 +61,7 @@ import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
-public class KvStateServerHandlerTest {
+public class KvStateServerHandlerTest extends TestLogger {
/** Shared Thread pool for query execution */
private final static ExecutorService TEST_THREAD_POOL = Executors.newSingleThreadExecutor();
@@ -148,8 +149,8 @@ public class KvStateServerHandlerTest {
int actualValue = KvStateRequestSerializer.deserializeValue(response.getSerializedResult(), IntSerializer.INSTANCE);
assertEquals(expectedValue, actualValue);
- assertEquals(1, stats.getNumRequests());
- assertEquals(1, stats.getNumSuccessful());
+ assertEquals(stats.toString(), 1, stats.getNumRequests());
+ assertEquals(stats.toString(), 1, stats.getNumSuccessful());
}
/**
@@ -251,8 +252,6 @@ public class KvStateServerHandlerTest {
assertEquals(requestId, response.getRequestId());
- System.out.println("RESPOINSE: " + response);
-
assertTrue("Did not respond with expected failure cause", response.getCause() instanceof UnknownKeyOrNamespace);
assertEquals(1, stats.getNumRequests());