You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "porcelli (via GitHub)" <gi...@apache.org> on 2024/11/02 10:37:51 UTC

[I] Remove binaries from test resources on main [incubator-kie-issues]

porcelli opened a new issue, #1602:
URL: https://github.com/apache/incubator-kie-issues/issues/1602

   Based on recent comment from @justinmclean [1][2] - we need properly remove binaries (compiled code) from our test resources.
   
   [1] https://lists.apache.org/thread/3176kvtgo0o9cljyzsc3dqj6svrxpd21 
   [2] https://lists.apache.org/thread/q6zp3v3lwxslh0mmydyzlb22r5ght2p8
   
   Related issue: https://github.com/apache/incubator-kie-issues/issues/1601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Remove binaries from test resources on main [incubator-kie-issues]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #1602:
URL: https://github.com/apache/incubator-kie-issues/issues/1602#issuecomment-2499435733

   Done by
   https://github.com/apache/incubator-kie-tools/pull/2722
   https://github.com/apache/incubator-kie-kogito-runtimes/pull/3759
   https://github.com/apache/incubator-kie-drools/pull/6141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Remove binaries from test resources on main [incubator-kie-issues]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #1602:
URL: https://github.com/apache/incubator-kie-issues/issues/1602#issuecomment-2456449207

   Hi @porcelli , we will rewrite the tests in `main` branch so that we don't need to have binaries in the codebase. But `10.0.x` branch will go with disabling the tests, correct? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Remove binaries from test resources on main [incubator-kie-issues]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on issue #1602:
URL: https://github.com/apache/incubator-kie-issues/issues/1602#issuecomment-2456821132

   thank you @tkobayas - for 10.0.x I already addressed removing and disabling everything. We just need address this on main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Remove binaries from test resources on main [incubator-kie-issues]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on issue #1602:
URL: https://github.com/apache/incubator-kie-issues/issues/1602#issuecomment-2453011609

   @thiagoelg https://github.com/apache/incubator-kie-tools/pull/2722
   @gitgabrio https://github.com/apache/incubator-kie-kogito-runtimes/pull/3759
   @mariofusco https://github.com/apache/incubator-kie-drools/pull/6141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Remove binaries from test resources on main [incubator-kie-issues]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on issue #1602:
URL: https://github.com/apache/incubator-kie-issues/issues/1602#issuecomment-2454449311

   Thank you for tracking `integration-tests-quarkus-gradle/pom.xml` comment @porcelli . Feel free to add me as reviewer for #1602 if needed once opened.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Remove binaries from test resources on main [incubator-kie-issues]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas closed issue #1602: Remove binaries from test resources on main
URL: https://github.com/apache/incubator-kie-issues/issues/1602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Remove binaries from test resources on main [incubator-kie-issues]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on issue #1602:
URL: https://github.com/apache/incubator-kie-issues/issues/1602#issuecomment-2453242761

   https://github.com/apache/incubator-kie-tools/blob/main/packages/dev-deployment-upload-service/tests/test.zip doesn't contain any compiled code, so I guess we can keep it on `main`. Nothing against removing it on `10.0.x` though, if it helps the release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Remove binaries from test resources on main [incubator-kie-issues]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on issue #1602:
URL: https://github.com/apache/incubator-kie-issues/issues/1602#issuecomment-2453437203

   @tiagobento we then need to add a NOTICE-BINARY file to justify it, for 10.0.0 better remove all the friction...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] Remove binaries from test resources on main [incubator-kie-issues]

Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on issue #1602:
URL: https://github.com/apache/incubator-kie-issues/issues/1602#issuecomment-2454384949

   @jomarko here
   
   https://github.com/apache/incubator-kie-kogito-runtimes/pull/3760#pullrequestreview-2412311451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org