You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/02/23 10:09:50 UTC

[jira] [Commented] (FLUME-968) Need a library that would allow external tools to parse and validate flume properties file configuration

    [ https://issues.apache.org/jira/browse/FLUME-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214481#comment-13214481 ] 

jiraposter@reviews.apache.org commented on FLUME-968:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4010/
-----------------------------------------------------------

(Updated 2012-02-23 09:07:56.494266)


Review request for Flume.


Summary
-------

This is a first cut for the library that does the syntactical validation of config files. I would like feedback on naming conventions for the errors and better ways to pass data around. Basically this patch is meant to demonstrate the fundamental idea.


This addresses bug FLUME-968.
    https://issues.apache.org/jira/browse/FLUME-968


Diffs
-----

  flume-ng-configuration/pom.xml PRE-CREATION 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION 
  flume-ng-node/pom.xml b9b062e 
  flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 
  flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 97f72e1 
  pom.xml d785762 

Diff: https://reviews.apache.org/r/4010/diff


Testing
-------

I will add tests once I get initial feedback.


Thanks,

Hari


                
> Need a library that would allow external tools to parse and validate flume properties file configuration
> --------------------------------------------------------------------------------------------------------
>
>                 Key: FLUME-968
>                 URL: https://issues.apache.org/jira/browse/FLUME-968
>             Project: Flume
>          Issue Type: Task
>    Affects Versions: v1.0.0
>            Reporter: Arvind Prabhakar
>             Fix For: v1.1.0
>
>         Attachments: FLUME-969-2.patch
>
>
> Currently the configuration provider implementation encompasses all the syntactic and structural validation rules for loading the configuration. Externalizing this functionality to a library will allow external tools to easily operate on flume configuration files and be able to help parse and validate these files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira