You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/10/18 03:31:43 UTC

[GitHub] [cordova-plugin-vibration] erisu opened a new pull request #100: ci(ios): update workflow w/ iOS 15

erisu opened a new pull request #100:
URL: https://github.com/apache/cordova-plugin-vibration/pull/100


   ### Platforms affected
   
   iOS
   
   ### Motivation, Context & Description
   
   Previously all iOS test appeared to run only on iOS 14.4.
   
   This PR:
   
   * Update GitHub Actions workflow to ensure that each defined iOS version was being tested correctly.
   * Included iOS 15.x to the workflow.
   
   ### Testing
   
   - CI
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-vibration] erisu merged pull request #100: ci(ios): update workflow w/ iOS 15

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #100:
URL: https://github.com/apache/cordova-plugin-vibration/pull/100


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-vibration] timbru31 commented on a change in pull request #100: ci(ios): update workflow w/ iOS 15

Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #100:
URL: https://github.com/apache/cordova-plugin-vibration/pull/100#discussion_r730822669



##########
File path: .github/workflows/ios.yml
##########
@@ -75,6 +87,12 @@ jobs:
           npm i -g cordova@latest ios-deploy@latest
           npm ci
 
+      - name: Run setup iOS 12.x support

Review comment:
       Do we have a reference why these calls are needed? Might help us in the future why it was needed. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-vibration] timbru31 commented on a change in pull request #100: ci(ios): update workflow w/ iOS 15

Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #100:
URL: https://github.com/apache/cordova-plugin-vibration/pull/100#discussion_r730840127



##########
File path: .github/workflows/ios.yml
##########
@@ -75,6 +87,12 @@ jobs:
           npm i -g cordova@latest ios-deploy@latest
           npm ci
 
+      - name: Run setup iOS 12.x support

Review comment:
       As discussed on Slack, we'll add a note on the paramedic template




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-vibration] erisu commented on a change in pull request #100: ci(ios): update workflow w/ iOS 15

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #100:
URL: https://github.com/apache/cordova-plugin-vibration/pull/100#discussion_r730944279



##########
File path: .github/workflows/ios.yml
##########
@@ -75,6 +87,12 @@ jobs:
           npm i -g cordova@latest ios-deploy@latest
           npm ci
 
+      - name: Run setup iOS 12.x support

Review comment:
       https://github.com/apache/cordova-paramedic/pull/229




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org