You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Forrest Xia (JIRA)" <ji...@apache.org> on 2008/10/16 12:08:44 UTC
[jira] Created: (GERONIMO-4366) Non-ASCII chars in deployment plan
xml files cause deployment failed with NPE on deployment time
Non-ASCII chars in deployment plan xml files cause deployment failed with NPE on deployment time
------------------------------------------------------------------------------------------------
Key: GERONIMO-4366
URL: https://issues.apache.org/jira/browse/GERONIMO-4366
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Affects Versions: 2.1.3
Environment: Any platforms
Reporter: Forrest Xia
Steps to recur:
1. checkout AG samples 2.1.2
2. build them
3. install jms-mdb-xxx.ear with plan "samples\jms-mdb\jms-mdb-tomcat\target\resources\META-INF\plan.xml" in admin console
You will get an NPE like this:
java.lang.NullPointerException
org.apache.geronimo.common.DeploymentException: java.lang.NullPointerException
at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:275)
at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:133)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:618)
at org.apache.geronimo.gbean.runtime.ReflectionMethodInvoker.invoke(ReflectionMethodInvoker.java:34)
at org.apache.geronimo.gbean.runtime.GBeanOperation.invoke(GBeanOperation.java:124)
at org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:867)
at org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:239)
at org.apache.geronimo.deployment.plugin.local.AbstractDeployCommand.doDeploy(AbstractDeployCommand.java:116)
at org.apache.geronimo.deployment.plugin.local.DistributeCommand.run(DistributeCommand.java:61)
at java.lang.Thread.run(Thread.java:810)
Caused by: java.lang.NullPointerException
at org.apache.geronimo.deployment.CopyResourceContext.addFile(CopyResourceContext.java:144)
at org.apache.geronimo.deployment.DeploymentContext.addFile(DeploymentContext.java:461)
at org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.installModule(AbstractWebModuleBuilder.java:289)
at org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.installModule(SwitchingModuleBuilder.java:153)
at org.apache.geronimo.j2ee.deployment.EARConfigBuilder.buildConfiguration(EARConfigBuilder.java:586)
at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:254)
... 12 more
To remove it, update all deployment plan files to remove any non-ascii chars, then rebuild and redeploy through admin console, it works!
So I doubt AG does not support any non-ASCII chars in deployment plan.
But for non-english environment, user might leave some comments including non-english chars in deployment plan, so it's necessary to take time to make our deployment plan could contain non-ASCII chars.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4366) Non-ASCII chars in deployment plan
xml files cause deployment failed with NPE on deployment time
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods closed GERONIMO-4366.
----------------------------------
Resolution: Won't Fix
If you want to include non-UTF8 chars in the XML file, then you need to change the specified XML encoding value first.
If changing the encoding to your locale charset doesn't work, then reopen, but please remember that we have never tested or claimed that Geronimo supports non-UTF8 charsets....
> Non-ASCII chars in deployment plan xml files cause deployment failed with NPE on deployment time
> ------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4366
> URL: https://issues.apache.org/jira/browse/GERONIMO-4366
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.3
> Environment: Any platforms
> Reporter: Forrest Xia
>
> Steps to recur:
> 1. checkout AG samples 2.1.2
> 2. build them
> 3. install jms-mdb-xxx.ear with plan "samples\jms-mdb\jms-mdb-tomcat\target\resources\META-INF\plan.xml" in admin console
> You will get an NPE like this:
> java.lang.NullPointerException
> org.apache.geronimo.common.DeploymentException: java.lang.NullPointerException
> at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:275)
> at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:133)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:618)
> at org.apache.geronimo.gbean.runtime.ReflectionMethodInvoker.invoke(ReflectionMethodInvoker.java:34)
> at org.apache.geronimo.gbean.runtime.GBeanOperation.invoke(GBeanOperation.java:124)
> at org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:867)
> at org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:239)
> at org.apache.geronimo.deployment.plugin.local.AbstractDeployCommand.doDeploy(AbstractDeployCommand.java:116)
> at org.apache.geronimo.deployment.plugin.local.DistributeCommand.run(DistributeCommand.java:61)
> at java.lang.Thread.run(Thread.java:810)
> Caused by: java.lang.NullPointerException
> at org.apache.geronimo.deployment.CopyResourceContext.addFile(CopyResourceContext.java:144)
> at org.apache.geronimo.deployment.DeploymentContext.addFile(DeploymentContext.java:461)
> at org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.installModule(AbstractWebModuleBuilder.java:289)
> at org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.installModule(SwitchingModuleBuilder.java:153)
> at org.apache.geronimo.j2ee.deployment.EARConfigBuilder.buildConfiguration(EARConfigBuilder.java:586)
> at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:254)
> ... 12 more
> To remove it, update all deployment plan files to remove any non-ascii chars, then rebuild and redeploy through admin console, it works!
> So I doubt AG does not support any non-ASCII chars in deployment plan.
> But for non-english environment, user might leave some comments including non-english chars in deployment plan, so it's necessary to take time to make our deployment plan could contain non-ASCII chars.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4366) Non-ASCII chars in deployment
plan xml files cause deployment failed with NPE on deployment time
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640290#action_12640290 ]
Donald Woods commented on GERONIMO-4366:
----------------------------------------
How were these non-ASCII chars introduced? Did your svn client create locale specific values for the $date field?
If so, this is a svn bug, as the XML files are marked with encoding=UTF-8 and should not contain any non-UTF8 chars.....
If you set your locale to en_US before running the svn co, does that fix the problem?
> Non-ASCII chars in deployment plan xml files cause deployment failed with NPE on deployment time
> ------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4366
> URL: https://issues.apache.org/jira/browse/GERONIMO-4366
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.3
> Environment: Any platforms
> Reporter: Forrest Xia
>
> Steps to recur:
> 1. checkout AG samples 2.1.2
> 2. build them
> 3. install jms-mdb-xxx.ear with plan "samples\jms-mdb\jms-mdb-tomcat\target\resources\META-INF\plan.xml" in admin console
> You will get an NPE like this:
> java.lang.NullPointerException
> org.apache.geronimo.common.DeploymentException: java.lang.NullPointerException
> at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:275)
> at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:133)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:618)
> at org.apache.geronimo.gbean.runtime.ReflectionMethodInvoker.invoke(ReflectionMethodInvoker.java:34)
> at org.apache.geronimo.gbean.runtime.GBeanOperation.invoke(GBeanOperation.java:124)
> at org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:867)
> at org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:239)
> at org.apache.geronimo.deployment.plugin.local.AbstractDeployCommand.doDeploy(AbstractDeployCommand.java:116)
> at org.apache.geronimo.deployment.plugin.local.DistributeCommand.run(DistributeCommand.java:61)
> at java.lang.Thread.run(Thread.java:810)
> Caused by: java.lang.NullPointerException
> at org.apache.geronimo.deployment.CopyResourceContext.addFile(CopyResourceContext.java:144)
> at org.apache.geronimo.deployment.DeploymentContext.addFile(DeploymentContext.java:461)
> at org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.installModule(AbstractWebModuleBuilder.java:289)
> at org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.installModule(SwitchingModuleBuilder.java:153)
> at org.apache.geronimo.j2ee.deployment.EARConfigBuilder.buildConfiguration(EARConfigBuilder.java:586)
> at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:254)
> ... 12 more
> To remove it, update all deployment plan files to remove any non-ascii chars, then rebuild and redeploy through admin console, it works!
> So I doubt AG does not support any non-ASCII chars in deployment plan.
> But for non-english environment, user might leave some comments including non-english chars in deployment plan, so it's necessary to take time to make our deployment plan could contain non-ASCII chars.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4366) Non-ASCII chars in deployment
plan xml files cause deployment failed with NPE on deployment time
Posted by "Forrest Xia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640451#action_12640451 ]
Forrest Xia commented on GERONIMO-4366:
---------------------------------------
Yep, the line like "<!-- $Rev$ $Date$ -->" embedded in some deployment plan is evaluated to the values of my local system when checking out, that causes some deployment plans include non-ASCII chars, and lead to this finding.
Seems this jira more like a feature request, right? Is it possible to have time investigating on this? Since adding non-english comments are common to developers in non-english countries :-)
If you think it's not a real bug, you can close it. thanks!
> Non-ASCII chars in deployment plan xml files cause deployment failed with NPE on deployment time
> ------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-4366
> URL: https://issues.apache.org/jira/browse/GERONIMO-4366
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1.3
> Environment: Any platforms
> Reporter: Forrest Xia
>
> Steps to recur:
> 1. checkout AG samples 2.1.2
> 2. build them
> 3. install jms-mdb-xxx.ear with plan "samples\jms-mdb\jms-mdb-tomcat\target\resources\META-INF\plan.xml" in admin console
> You will get an NPE like this:
> java.lang.NullPointerException
> org.apache.geronimo.common.DeploymentException: java.lang.NullPointerException
> at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:275)
> at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:133)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:618)
> at org.apache.geronimo.gbean.runtime.ReflectionMethodInvoker.invoke(ReflectionMethodInvoker.java:34)
> at org.apache.geronimo.gbean.runtime.GBeanOperation.invoke(GBeanOperation.java:124)
> at org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:867)
> at org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:239)
> at org.apache.geronimo.deployment.plugin.local.AbstractDeployCommand.doDeploy(AbstractDeployCommand.java:116)
> at org.apache.geronimo.deployment.plugin.local.DistributeCommand.run(DistributeCommand.java:61)
> at java.lang.Thread.run(Thread.java:810)
> Caused by: java.lang.NullPointerException
> at org.apache.geronimo.deployment.CopyResourceContext.addFile(CopyResourceContext.java:144)
> at org.apache.geronimo.deployment.DeploymentContext.addFile(DeploymentContext.java:461)
> at org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.installModule(AbstractWebModuleBuilder.java:289)
> at org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.installModule(SwitchingModuleBuilder.java:153)
> at org.apache.geronimo.j2ee.deployment.EARConfigBuilder.buildConfiguration(EARConfigBuilder.java:586)
> at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:254)
> ... 12 more
> To remove it, update all deployment plan files to remove any non-ascii chars, then rebuild and redeploy through admin console, it works!
> So I doubt AG does not support any non-ASCII chars in deployment plan.
> But for non-english environment, user might leave some comments including non-english chars in deployment plan, so it's necessary to take time to make our deployment plan could contain non-ASCII chars.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.