[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5715: Support alias name to be same as selection

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5715:
URL: https://github.com/apache/incubator-pinot/pull/5715#discussion_r457626980



##########
File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -113,32 +113,11 @@ private static void validateSelectionClause(Map<Identifier, Expression> aliasMap
     // Sanity check on selection expression shouldn't use alias reference.

Review comment:
       We should not remove the sanity check on usage of alias reference
   E.g. we should reject the following query:
   ```
   SELECT colA AS a, foo(a, colB) FROM table
   ```
   
   Another way is to replace the alias reference in selection as well




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org