[GitHub] [airflow] potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704]
URL: https://github.com/apache/airflow/pull/6266#discussion_r336985423
 
 

 ##########
 File path: .pre-commit-config.yaml
 ##########
 @@ -20,21 +20,6 @@ default_language_version:
   # force all unspecified python hooks to run python3
   python: python3
 repos:
-  - repo: local
-    hooks:
-      - id: build
-        name: Check if image build is needed
-        entry: ./scripts/ci/local_ci_build.sh
-        language: system
-        always_run: true
-        pass_filenames: false
-      - id: check-apache-license
 
 Review comment:
   I moved those so that checking for image is done as late as possible - just before it is needed. Most pre-commit checks do not require breeze's image - only few of them (mypy/pylint/flake) are done using image to make sure they are run in the same environment. By moving "build" closer to the end, we can get those (much faster) pre-commit checks to be executed immediately and give feedback immediately - then somebody might decide to skip building image (and press Ctrl-C) seeing some other errors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services