You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "thswlsqls (via GitHub)" <gi...@apache.org> on 2026/07/09 01:02:14 UTC
[PR] Refine agent API Javadoc wording and punctuation [shardingsphere]
thswlsqls opened a new pull request, #39058:
URL: https://github.com/apache/shardingsphere/pull/39058
No issue: typo fix.
Changes proposed in this pull request:
- `InstanceMethodAdvice.afterMethod`: add the missing terminal period to the Javadoc line `It will invoke after the origin calling`, matching the sibling `StaticMethodAdvice.afterMethod` and this interface's own `beforeMethod`, which both end with a period.
- `TargetAdviceObject`: fix the class Javadoc grammar from `Wrapped class for target and provide a context to store variable during invocation.` to `Wrapper class for target and provides a context to store variables during invocation.`
- Javadoc prose only; no signature, behavior, or import changes.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refine agent API Javadoc wording and punctuation [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39058:
URL: https://github.com/apache/shardingsphere/pull/39058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org