You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by martincgg <gi...@git.apache.org> on 2014/08/28 23:58:56 UTC
[GitHub] cordova-plugin-file pull request: [CB-7375][Entry] set proper file...
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/76
[CB-7375][Entry] set proper filesystem in Entry, when moveTo or copyTo
When the native side it doesn't return any kind of value related directly related with the fileSystem, it has to be recreated after a copy, however, it makes perfect sense, that when the entry for the copied or moved file if there's no value in entry.fileSystem, it takes the filesystem property from the parent directory that it has been moved to or copied to. So instead of return a null object or take the previous filesystem(origin) from wherever location it was copied or moved from. It would be better take the parent filesystem name and recreate it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-plugin-file CB-7375
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit 84ea94a94e68c2f4ef5c28ec91338b5932f44610
Author: Martin Gonzalez <ma...@gmail.com>
Date: 2014-08-28T21:53:10Z
[CB-7375][Entry] get proper filesystem in Entry
When the native side it doesn't return any kind of value related
directly with the fileSystem, it has to be recreated after a copy,
however, it makes perfect sense that, when the entry for the copied or
moved file if there's no value in entry.fileSystem, it takes the
filesystem property from the parent directory that it has been moved to
or copied to. So instead of return a null object or take the previous
filesystem(origin) from whatever location it was copied from. It would
be better take the parent filesystem name and recreate it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: [CB-7375][Entry] set proper file...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: [CB-7375][Entry] set proper file...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/76#issuecomment-53815245
I've tested this over Android and WP8, it looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---