You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2025/02/12 19:30:48 UTC
[PR] Changes exception prefix from Invalid to Illegal [accumulo-access]
keith-turner opened a new pull request, #85:
URL: https://github.com/apache/accumulo-access/pull/85
Renamed InvalidAccessExpressionException to
IllegalAccessExpressionException because it extends IllegalArgumentException. So now it uses the same terminology as its parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes exception prefix from Invalid to Illegal [accumulo-access]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #85:
URL: https://github.com/apache/accumulo-access/pull/85#issuecomment-2657588162
@ctubbsii those reasons all SGTM for changing the name back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes exception prefix from Invalid to Illegal [accumulo-access]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #85:
URL: https://github.com/apache/accumulo-access/pull/85#issuecomment-2657600509
Okay, reverted in 6112180245fb8e1aed41b8327e4d773ddc735aaf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes exception prefix from Invalid to Illegal [accumulo-access]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #85:
URL: https://github.com/apache/accumulo-access/pull/85#issuecomment-2657522341
@keith-turner are you sure this is a good idea? Changing it to begin with "IllegalAccess" makes it seem like it's related to https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/IllegalAccessException.html or https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/IllegalAccessError.html, which is not what this is. In this case, it's only an illegal argument because the access expression is invalid, so I think the previous name still makes sense. At the very least, the word "illegal" seems to imply "disallowed" but without a reason why. "Invalid", on the other hand, makes it clear that it's disallowed because it's not a valid access expression. Given the potential for confusion, and the loss of the clarity about validity/lack thereof, I think it's better to stick with the old name. I'm not sure there's a compelling reason to make the exception match the parent's name. Making it the same prefix just to make it the same isn't really compelling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Changes exception prefix from Invalid to Illegal [accumulo-access]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #85:
URL: https://github.com/apache/accumulo-access/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org