You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/02/06 16:09:12 UTC
[GitHub] incubator-brooklyn pull request: various 20150206
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/507
various 20150206
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/various-20150206
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/507.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #507
----
commit c9693fee94f3b1469c54f4d65c809d2b22a15a75
Author: Aled Sage <al...@gmail.com>
Date: 2015-02-06T15:06:00Z
Transformer enricher: tidy import
commit 0ecf677ee8fd26b2fc4d35187421bd155c7b8c11
Author: Aled Sage <al...@gmail.com>
Date: 2015-02-06T15:06:16Z
Entities.destroyAll: stop apps concurrently
commit 83aa2d62da59401672940fc5542c9721f1b11ffb
Author: Aled Sage <al...@gmail.com>
Date: 2015-02-06T15:07:40Z
Adds EntityAndAttribute.create(...)
It’s nicer to use than the constructor because you don’t need to
specify generics and don’t get warned about it. However, not everyone
is used to such static methods so leaving the constructor as well
for ease of discovery.
Deprecates the old supplier() method, which should really have been
called create().
commit 8d015a8f31147a4a03b043806d52d9f6a4f1aef8
Author: Aled Sage <al...@gmail.com>
Date: 2015-02-06T15:08:12Z
AbstractBlueprintTest: make fields/methods protected
Make it more useful for sub-classing in downstream projects.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: various 20150206
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/507
various 20150206
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/various-20150206
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/507.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #507
----
commit c9693fee94f3b1469c54f4d65c809d2b22a15a75
Author: Aled Sage <al...@gmail.com>
Date: 2015-02-06T15:06:00Z
Transformer enricher: tidy import
commit 0ecf677ee8fd26b2fc4d35187421bd155c7b8c11
Author: Aled Sage <al...@gmail.com>
Date: 2015-02-06T15:06:16Z
Entities.destroyAll: stop apps concurrently
commit 83aa2d62da59401672940fc5542c9721f1b11ffb
Author: Aled Sage <al...@gmail.com>
Date: 2015-02-06T15:07:40Z
Adds EntityAndAttribute.create(...)
It’s nicer to use than the constructor because you don’t need to
specify generics and don’t get warned about it. However, not everyone
is used to such static methods so leaving the constructor as well
for ease of discovery.
Deprecates the old supplier() method, which should really have been
called create().
commit 8d015a8f31147a4a03b043806d52d9f6a4f1aef8
Author: Aled Sage <al...@gmail.com>
Date: 2015-02-06T15:08:12Z
AbstractBlueprintTest: make fields/methods protected
Make it more useful for sub-classing in downstream projects.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: various 20150206
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/507#issuecomment-73254416
Failure is unrelated: "Port already in use: 40125". Perhaps `JmxFeedTest` should be marked `groups="Integration"`, or perhaps it should retry on more ports?
Closing and re-opening to kick off build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: various 20150206
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/507#issuecomment-73270709
lgtm +1. Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: various 20150206
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: various 20150206
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---