You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "thiagoelg (via GitHub)" <gi...@apache.org> on 2024/09/11 15:14:52 UTC
[PR] NO-ISSUE: Use `image-builder` and `maven-m2-repo-via-http-image` to build `serverless-logic-web-tools-swf-dev-mode-image` [incubator-kie-tools]
thiagoelg opened a new pull request, #2574:
URL: https://github.com/apache/incubator-kie-tools/pull/2574
This PR refactors the build process of the `serverless-logic-web-tools-swf-dev-mode-image` package to use our `image-builder` and `maven-m2-repo-via-http-image` tools.
With this change, the local m2 repository is served via a Docker container inside the same Docker network as the builder container, making it possible to fetch all locally built dependencies to Maven during build/install.
The dev-mode image now runs in offline mode, as the m2-repo container is unavailable during runtime. Still, all dependencies should already be available inside the container's filesystem (in /home/kogito/.m2/repository).
The `--ulimit nofile=5000:5000` flags from the Docker build command were removed as `image-builder` doesn't support passing flags to the Docker CLI for now. If the CI breaks, we can implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use `image-builder` and `maven-m2-repo-via-http-image` to build `serverless-logic-web-tools-swf-dev-mode-image` [incubator-kie-tools]
Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli commented on PR #2574:
URL: https://github.com/apache/incubator-kie-tools/pull/2574#issuecomment-2348423028
@thiagoelg I'm sorry I still have this error, what am I missing?
```
[INFO] --- quarkus-maven-plugin:3.8.6:dev (default-cli) @ serverless-logic-web-tools-swf-deployment-quarkus-app ---
[INFO] Invoking enforcer:3.4.1:enforce (enforce-maven-version) @ serverless-logic-web-tools-swf-deployment-quarkus-app
[INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireMavenVersion passed
[INFO] Invoking enforcer:3.4.1:enforce (enforce-java-version) @ serverless-logic-web-tools-swf-deployment-quarkus-app
[INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion passed
[INFO] Invoking remote-resources:3.2.0:process (process-resource-bundles) @ serverless-logic-web-tools-swf-deployment-quarkus-app
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO] Invoking resources:3.3.1:resources (default-resources) @ serverless-logic-web-tools-swf-deployment-quarkus-app
[INFO] Copying 230 resources from src/main/resources to target/classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16.501 s
[INFO] Finished at: 2024-09-13T08:24:27Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:3.8.6:dev (default-cli) on project serverless-logic-web-tools-swf-deployment-quarkus-app: copying /home/kogito/serverless-logic-web-tools-swf-deployment-quarkus-app/src/main/resources/application.properties to /home/kogito/serverless-logic-web-tools-swf-deployment-quarkus-app/target/classes/application.properties failed with FileSystemException: /home/kogito/serverless-logic-web-tools-swf-deployment-quarkus-app/target/classes/application.properties: Operation not permitted -> [Help 1]
[ERROR]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use `image-builder` and `maven-m2-repo-via-http-image` to build `serverless-logic-web-tools-swf-dev-mode-image` [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2574:
URL: https://github.com/apache/incubator-kie-tools/pull/2574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use `image-builder` and `maven-m2-repo-via-http-image` to build `serverless-logic-web-tools-swf-dev-mode-image` [incubator-kie-tools]
Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli commented on PR #2574:
URL: https://github.com/apache/incubator-kie-tools/pull/2574#issuecomment-2344330491
I still have to read all the code.
In OpenShift I get the error `ImagePullBackOff`
"Back-off pulling image "docker.io/apache/incubator-serverless-logic-web-tools-swf-dev-mode:main""
Are we supposed to wait the release to test this as it is under apache path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use `image-builder` and `maven-m2-repo-via-http-image` to build `serverless-logic-web-tools-swf-dev-mode-image` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on PR #2574:
URL: https://github.com/apache/incubator-kie-tools/pull/2574#issuecomment-2343964637
@fantonangeli can you help validate that the image still works as expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use `image-builder` and `maven-m2-repo-via-http-image` to build `serverless-logic-web-tools-swf-dev-mode-image` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on PR #2574:
URL: https://github.com/apache/incubator-kie-tools/pull/2574#issuecomment-2346345924
@fantonangeli can you provide the steps to reproduce this? I think I know how to fix it, but I need to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use `image-builder` and `maven-m2-repo-via-http-image` to build `serverless-logic-web-tools-swf-dev-mode-image` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on PR #2574:
URL: https://github.com/apache/incubator-kie-tools/pull/2574#issuecomment-2348922317
@fantonangeli Your OCP cluster probably cached the previous version (to always pull the image, the Deployment needs to be configured with `imagePullPolicy: Always`)
I've published the same image under the `latest` tag now. Could you try that? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use `image-builder` and `maven-m2-repo-via-http-image` to build `serverless-logic-web-tools-swf-dev-mode-image` [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on PR #2574:
URL: https://github.com/apache/incubator-kie-tools/pull/2574#issuecomment-2347591286
Updated the PR to include two changes:
- Used a mounted path (`/tmp/app`) to copy all executable and mutable files and run the app from there (check `entrypoint.sh`);
- Added the memory resource limit to `4096Mi`. This allows the image to run on an OpenShift Developer Sandbox.
I tested it with a JSONGreet example, and it worked fine on the Dev UI, but the webapp that can be accessed via this "Dev Mode for Serverless Workflow" button crashed and never recovered (I'm not sure if this was happening before this change or if it's an out of memory thing).
<img width="475" alt="image" src="https://github.com/user-attachments/assets/42f35d67-fdd1-4b03-b912-87898969ca95">
----
The Dev UI:
<img width="1711" alt="image" src="https://github.com/user-attachments/assets/5285ec0d-dce8-4000-b89d-a1a4a3c1a895">
The Dev Mode for Serverless Workflow webapp:
<img width="1711" alt="image" src="https://github.com/user-attachments/assets/cbbf70ef-fdac-46da-9da7-af08ae9adc26">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Use `image-builder` and `maven-m2-repo-via-http-image` to build `serverless-logic-web-tools-swf-dev-mode-image` [incubator-kie-tools]
Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli commented on PR #2574:
URL: https://github.com/apache/incubator-kie-tools/pull/2574#issuecomment-2346552469
@thiagoelg pinged on Zulip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org