[GitHub] [superset] graceguo-supercat edited a comment on issue #19015: [2.0] generally remove all code marked as "deprecated" (front end)

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on issue #19015:
URL: https://github.com/apache/superset/issues/19015#issuecomment-1063514579


   @eschutho  and I went through superset-frontend code base and found 2 deprecation candidates:
   
   - https://github.com/apache/superset/blob/e632193eb00803594a1bbc20c2f6cb6fb29deb1f/superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts#L78
   in use by "OMNIBAR" feature
   
   - https://github.com/apache/superset/blob/e6ef7da7584d6ab40ff090213b16ed0e53550ef2/superset-frontend/src/components/OmniContainer/Omnibar.tsx#L30
   in use by `table`, `pivot table`, `big number` visualization.
   
   But both of them are currently in use and no replacement code available. So we think it's not a right time to deprecate them right now.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org