[GitHub] [mynewt-newt] andrzej-kaczmarek opened a new pull request #462: Fix restrictions evaluation

[GitBox <gi...@apache.org>]

andrzej-kaczmarek opened a new pull request #462:
URL: https://github.com/apache/mynewt-newt/pull/462


   The resolving process seems to not update restrictions properly in some
   cases. Here's how it fails to update them:
   
   1. reloadCfg loads settings and restrictions (and other data too, but
      that's not relevant here) for all packages resolved in previous pass
   2. configuration change is detected
   3. dependencies are resolved
   
   At this point package X is added due to pkg.deps constraints based on
   syscfg Y.
   
   4. reloadCfg loads settings and restrictions again
   5. configuration change is detected
   6. dependencies are resolved one more time
   
   At this point, syscfg Y changed and package X is removed as previous
   pkg.deps constraints do not apply anymore. Removing package X means
   r.cfg.Settings is updated - this is crucial here.
   
   7. reloadCfg load settings and restrictions one more time
   
   And here's the problem: it does not detect that settings have changed
   since those from removed package were already removed in previous pass.
   Consequently it does not update r.cfg so restrictions state is kept
   from previous pass, i.e. before package X was removed.
   
   This can be fixed by always updating r.cfg to latest configuration as
   load by reloadCfg.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-newt] andrzej-kaczmarek merged pull request #462: Fix restrictions evaluation

[GitBox <gi...@apache.org>]

andrzej-kaczmarek merged pull request #462:
URL: https://github.com/apache/mynewt-newt/pull/462


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org