You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ki...@apache.org on 2020/02/02 11:15:56 UTC
svn commit: r1873499 -
/poi/trunk/src/java/org/apache/poi/sl/draw/geom/PresetGeometries.java
Author: kiwiwings
Date: Sun Feb 2 11:15:56 2020
New Revision: 1873499
URL: http://svn.apache.org/viewvc?rev=1873499&view=rev
Log:
XSLF Performance - don't initialize the JAXBContext every time
Modified:
poi/trunk/src/java/org/apache/poi/sl/draw/geom/PresetGeometries.java
Modified: poi/trunk/src/java/org/apache/poi/sl/draw/geom/PresetGeometries.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/sl/draw/geom/PresetGeometries.java?rev=1873499&r1=1873498&r2=1873499&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/sl/draw/geom/PresetGeometries.java (original)
+++ poi/trunk/src/java/org/apache/poi/sl/draw/geom/PresetGeometries.java Sun Feb 2 11:15:56 2020
@@ -38,12 +38,24 @@ import org.apache.poi.util.POILogger;
import org.apache.poi.util.XMLHelper;
/**
- *
+ *
*/
public class PresetGeometries extends LinkedHashMap<String, CustomGeometry> {
private final static POILogger LOG = POILogFactory.getLogger(PresetGeometries.class);
- protected final static String BINDING_PACKAGE = "org.apache.poi.sl.draw.binding";
-
+ private final static String BINDING_PACKAGE = "org.apache.poi.sl.draw.binding";
+
+ private static class SingletonHelper {
+ private static JAXBContext JAXB_CONTEXT;
+ static {
+ try {
+ JAXB_CONTEXT = JAXBContext.newInstance(BINDING_PACKAGE);
+ } catch (JAXBException e) {
+ throw new RuntimeException(e);
+ }
+ }
+ }
+
+
protected static PresetGeometries _inst;
protected PresetGeometries(){}
@@ -57,7 +69,7 @@ public class PresetGeometries extends Li
streamReader.nextTag();
// JAXB:
- JAXBContext jaxbContext = JAXBContext.newInstance(BINDING_PACKAGE);
+ JAXBContext jaxbContext = SingletonHelper.JAXB_CONTEXT;
Unmarshaller unmarshaller = jaxbContext.createUnmarshaller();
long cntElem = 0;
@@ -76,13 +88,13 @@ public class PresetGeometries extends Li
streamReader.close();
}
}
-
+
/**
* Convert a single CustomGeometry object, i.e. from xmlbeans
*/
public static CustomGeometry convertCustomGeometry(XMLStreamReader staxReader) {
try {
- JAXBContext jaxbContext = JAXBContext.newInstance(BINDING_PACKAGE);
+ JAXBContext jaxbContext = SingletonHelper.JAXB_CONTEXT;
Unmarshaller unmarshaller = jaxbContext.createUnmarshaller();
JAXBElement<CTCustomGeometry2D> el = unmarshaller.unmarshal(staxReader, CTCustomGeometry2D.class);
return new CustomGeometry(el.getValue());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org