You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/02/23 16:03:11 UTC

[jira] [Commented] (WICKET-5749) Wicket-auth-roles should deal with resource authorization

    [ https://issues.apache.org/jira/browse/WICKET-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333372#comment-14333372 ] 

ASF GitHub Bot commented on WICKET-5749:
----------------------------------------

GitHub user duesenklipper opened a pull request:

    https://github.com/apache/wicket/pull/99

    WICKET-5749 add AuthorizeResource to auth-roles so Resources can be prot...

    WICKET-5749 add AuthorizeResource to auth-roles so Resources can be protected too.
    
    Also cleaned up and expanded AnnotationsRoleAuthorizationStrategyTest.
    
    
    It's been a while since I contributed, so I figured I'd go with a pull request for review first. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/duesenklipper/wicket sandbox/WICKET-5749

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #99
    
----
commit b8b9b30173921215972238a34395725a08c70fb3
Author: Carl-Eric Menzel <cm...@wicketbuch.de>
Date:   2015-02-23T14:39:48Z

    WICKET-5749 add AuthorizeResource to auth-roles so Resources can be protected too
    
    Also cleaned up and expanded AnnotationsRoleAuthorizationStrategyTest.

----


> Wicket-auth-roles should deal with resource authorization
> ---------------------------------------------------------
>
>                 Key: WICKET-5749
>                 URL: https://issues.apache.org/jira/browse/WICKET-5749
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-auth-roles
>    Affects Versions: 7.0.0-M3
>            Reporter: Carl-Eric Menzel
>            Assignee: Carl-Eric Menzel
>            Priority: Minor
>
> We now have IAuthorizationStrategy.isResourceAuthorized, which is awesome. So far, wicket-auth-roles's implementation allows all resources to go through without any possibility of configuring that.
> I think the default auth strategy shipped with Wicket should support this :-)
> Perhaps an additional annotation like "@AuthorizeResource"?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)