You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/28 09:44:03 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #634: Bug fixes
davidjumani opened a new pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634
Fixes :
https://github.com/apache/cloudstack-primate/issues/604
Also : Hide cance button while deploying a vm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#discussion_r479050862
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -1409,7 +1409,6 @@ export default {
this.$router.back()
}).catch(error => {
this.$notifyError(error)
- }).finally(() => {
Review comment:
Shouldn't we reset in finally? Otherwise it will reset only on error. Or, is the logic that on VM deployment we'll change view so this is not necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-683556825
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/634 (JID-3395)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682433770
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#discussion_r479053645
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -1409,7 +1409,6 @@ export default {
this.$router.back()
}).catch(error => {
this.$notifyError(error)
- }).finally(() => {
Review comment:
On success, it goes back to the previous page. If we keep it in finally, the button will show up for a second before the page redirects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682443125
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/634 (JID-3387)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682440535
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-683554056
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-683553807
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#discussion_r479049921
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -505,7 +505,7 @@
</a-steps>
<div class="card-footer">
<!-- ToDo extract as component -->
- <a-button @click="() => this.$router.back()" :loading="loading.deploy">
+ <a-button @click="() => this.$router.back()" v-if="!this.loading.deploy">
Review comment:
@davidjumani I think disable would make sense instead of hide?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682450253
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/634 (JID-3388)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682441130
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #634:
URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682434287
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org