[jira] [Created] (OFBIZ-5121) HTML Validation error - Duplicate DIV id is created in tag.

["Sumit Pandit (JIRA)" <ji...@apache.org>]

Sumit Pandit created OFBIZ-5121:
-----------------------------------

             Summary: HTML Validation error - Duplicate DIV id is created in <screenlet title=.../> tag.
                 Key: OFBIZ-5121
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5121
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 11.04, SVN trunk, Release Branch 12.04
            Reporter: Sumit Pandit
            Priority: Critical


When ID has not been provided in <screenlet title=.../> tag, The generated DIV has an ID="_col". Including multiple screenlet in a page get result in multiple DIVs with duplicate ID ("_col"). 

For reference find duplicate div id("_col") in following page -  
{code} https://demo-trunk.ofbiz.apache.org/catalog/control/EditProdCatalogCategories?prodCatalogId=DemoCatalog {code}


Possible fix could be as follows - 
{code:title="MacroScreenRenderer.java"}
- parameters.put("collapsibleAreaId", screenlet.getId(context) + "_col");
+ if (UtilValidate.isNotEmpty (screenlet.getId(context))) {
+     parameters.put("collapsibleAreaId", screenlet.getId(context) + "_col");
+ } else {
+     parameters.put("collapsibleAreaId", null);
+ }
{code}

In similar way MacroFormRenderer.java can be modified.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira